Deprecate :local.(args) syntax

Author: José Valim

lib/eex/lib/eex.ex

@@ -191,7 +191,7 @@ defmodule EEx do
   def function_from_quoted(module, kind, name, args, source, info) do
     args  = Enum.map args, fn arg -> { arg, [], nil } end
     quote = quote do
-      unquote(kind).(unquote(name).(unquote_splicing(args)), do: unquote(source))
+      unquote(kind)(unquote(name)(unquote_splicing(args)), do: unquote(source))
     end
     Module.eval_quoted module, quote, [], info
   end

lib/elixir/lib/kernel.ex

@@ -1260,7 +1260,7 @@ defmodule Kernel do
       defmacro defkv(keywords) do
         Enum.map keywords, fn {k,v} ->
           quote do
-            def unquote(k).() do
+            def unquote(k)() do
               unquote(v)
             end
           end
@@ -1271,9 +1271,6 @@ defmodule Kernel do
 
       defkv one: 1, two: 2
 
-  Notice in the example above, we define the function as `def unquote(k).()`
-  because each entry `k` is a an atom and invoking `def unquote(k)()`
-  would be invalid Elixir syntax.
   """
   defmacro def(name, do: contents)
 
@@ -3051,7 +3048,7 @@ defmodule Kernel do
       fun = Keyword.get(opts, :as, name)
 
       quote do
-        def unquote(name).(unquote_splicing(args)) do
+        def unquote(name)(unquote_splicing(args)) do
           apply unquote(target), unquote(fun), [unquote_splicing(actual_args)]
         end
       end

lib/elixir/lib/protocol.ex

@@ -287,7 +287,7 @@ defmodule Protocol do
   # Generate all others protocols.
   defp each_impl_for({ kind, fun, _ }, _, _) do
     quote do
-      defp __raw_impl__(arg) when unquote(fun).(arg) do
+      defp __raw_impl__(arg) when unquote(fun)(arg) do
         __MODULE__.unquote(kind)
       end
     end
@@ -404,7 +404,7 @@ defmodule Protocol.DSL do
 
       # Generate a fake definition with the user
       # signature that will be used by docs
-      Kernel.def unquote(name).(unquote_splicing(args))
+      Kernel.def unquote(name)(unquote_splicing(args))
 
       { args, body } = Protocol.DSL.args_and_body(__MODULE__, name, arity)
       Kernel.def unquote(name), args, [], do: body

lib/elixir/lib/record.ex

@@ -131,23 +131,23 @@ defmodule Record do
     end
 
     contents = quote do
-      defmacrop unquote(name).() do
+      defmacrop unquote(name)() do
         Record.access(__MODULE__, unquote(escaped), [], __CALLER__)
       end
 
-      defmacrop unquote(name).(record) when is_tuple(record) do
+      defmacrop unquote(name)(record) when is_tuple(record) do
         Record.to_keywords(__MODULE__, unquote(escaped), record)
       end
 
-      defmacrop unquote(name).(args) do
+      defmacrop unquote(name)(args) do
         Record.access(__MODULE__, unquote(escaped), args, __CALLER__)
       end
 
-      defmacrop unquote(name).(record, key) when is_atom(key) do
+      defmacrop unquote(name)(record, key) when is_atom(key) do
         Record.get(__MODULE__, unquote(escaped), record, key)
       end
 
-      defmacrop unquote(name).(record, args) do
+      defmacrop unquote(name)(record, args) do
         Record.dispatch(__MODULE__, unquote(escaped), record, args, __CALLER__)
       end
     end
@@ -465,17 +465,17 @@ defmodule Record do
 
     contents = quote do
       @doc false
-      def unquote(key).(record) do
+      def unquote(key)(record) do
         :erlang.element(unquote(i + 1), record)
       end
 
       @doc false
-      def unquote(key).(value, record) do
+      def unquote(key)(value, record) do
         :erlang.setelement(unquote(i + 1), record, value)
       end
 
       @doc false
-      def unquote(update).(function, record) do
+      def unquote(update)(function, record) do
         :erlang.setelement(unquote(i + 1), record,
           function.(:erlang.element(unquote(i + 1), record)))
       end

lib/elixir/src/elixir_translator.erl

@@ -468,10 +468,11 @@ translate_each({ { '.', _, [Left, Right] }, Meta, Args } = Original, S) when is_
 
 %% Anonymous function calls
 
-translate_each({ { '.', _, [Expr] }, Meta, Args } = Original, S) ->
+translate_each({ { '.', Line, [Expr] }, Meta, Args } = Original, S) ->
   { TExpr, SE } = translate_each(Expr, S),
   case TExpr of
     { atom, _, Atom } ->
+      elixir_errors:deprecation(?line(Line), S#elixir_scope.file, "the :~s.() syntax is deprecated, please use ~s() instead", [Atom, Atom]),
       translate_each({ Atom, Meta, Args }, S);
     _ ->
       case elixir_partials:handle(Original, S) of

lib/elixir/test/elixir/kernel/partial_application_test.exs

@@ -15,12 +15,6 @@ defmodule Kernel.PartialApplicationTest do
     assert fun.(13, 6) == 7
   end
 
-  test :partial_with_atom_call_and_one_item do
-    fun = :minus.(10, &1)
-    assert fun.(5) == 5
-    assert fun.(3) == 7
-  end
-
   test :partial_with_funcall_and_one_item do
     fun = minus(&1, &2)
     fun = fun.(10, &1)

lib/elixir/test/elixir/list_test.exs

@@ -3,13 +3,9 @@ Code.require_file "../test_helper.exs", __FILE__
 defmodule ListTest do
   use ExUnit.Case, async: true
 
-  test :brackets_function do
-    assert :[].(1,2,3) == [1,2,3]
-  end
-
   test :optional_comma do
-    assert :[].(1,) == [ 1, ]
-    assert :[].(1,2,3,) == [1,2,3,]
+    assert [1] == [ 1, ]
+    assert [1,2,3] == [1,2,3,]
   end
 
   test :partial_application do

lib/elixir/test/elixir/tuple_test.exs

@@ -12,8 +12,8 @@ defmodule TupleTest do
   end
 
   test :optional_comma do
-    assert :{}.(1,) == { 1, }
-    assert :{}.(1, 2, 3) == { 1, 2, 3, }
+    assert { 1 } == { 1, }
+    assert { 1, 2, 3 } == { 1, 2, 3, }
   end
 
   test :partial_application do

lib/ex_unit/lib/ex_unit/assertions.ex

@@ -164,7 +164,7 @@ defmodule ExUnit.Assertions do
     quote do
       left  = unquote(expected)
       right = unquote(actual)
-      assert unquote(operator).(left, right), left, right, reason: unquote(text)
+      assert unquote(operator)(left, right), left, right, reason: unquote(text)
     end
   end