Merge pull request #2367 from chyndman/file-rm-windows-read-write

File.rm makes files writeable on Windows before deletion

Author: José Valim

lib/elixir/lib/file.ex

@@ -765,6 +765,15 @@ defmodule File do
   """
   @spec rm(Path.t) :: :ok | {:error, posix}
   def rm(path) do
+    if match? {:win32, _}, :os.type do
+      case F.read_file_info(IO.chardata_to_string(path)) do
+        {:ok, file_info} ->
+          if elem(file_info, 3) in [:read, :none] do
+            File.chmod(path, (elem(file_info, 7) + 0200))
+          end
+        {:error, reason} -> {:error, reason}
+      end
+    end
     F.delete(IO.chardata_to_string(path))
   end
 

lib/elixir/test/elixir/file_test.exs

@@ -688,6 +688,15 @@ defmodule FileTest do
       assert File.rm(fixture) == :ok
       refute File.exists?(fixture)
     end
+    
+    test :rm_read_only_file do
+      fixture = tmp_path("tmp_test.txt")
+      File.write(fixture, "test")
+      assert File.exists?(fixture)
+      File.chmod(fixture, 0100444)
+      assert File.rm(fixture) == :ok
+      refute File.exists?(fixture)
+    end
 
     test :rm_file_with_dir do
       assert File.rm(fixture_path) == {:error, :eperm}