Fix warnings in Logger and CI

Author: josevalim

.github/workflows/ci.yml

@@ -45,7 +45,7 @@ jobs:
           otp-version: ${{ matrix.otp_version }}
       - name: Set ERL_COMPILER_OPTIONS
         if: ${{ matrix.deterministic }}
-        run: echo 'ERL_COMPILER_OPTIONS="deterministic warnings_as_errors"' >> $GITHUB_ENV
+        run: echo 'ERL_COMPILER_OPTIONS="[deterministic,warnings_as_errors]"' >> $GITHUB_ENV
       - name: Compile Elixir
         run: |
           make compile

lib/elixir/lib/module/types.ex

@@ -30,7 +30,6 @@ defmodule Module.Types do
         end)
 
       # TODO: Reuse context from patterns and guards
-      # TODO: Fix logger errors
       {{fun, arity}, {:infer, Enum.reverse(pair_types)}}
     end
   end

lib/logger/test/logger_test.exs

@@ -346,8 +346,10 @@ defmodule LoggerTest do
              end) == ""
 
       assert capture_log(:info, fn ->
-               assert Logger.debug(raise("not invoked"), []) == :ok
+               assert Logger.debug(send(self(), :something), []) == :ok
              end) == ""
+
+      refute_received :something
     end
 
     test "info/2" do
@@ -360,8 +362,10 @@ defmodule LoggerTest do
              end) == ""
 
       assert capture_log(:notice, fn ->
-               assert Logger.info(raise("not invoked"), []) == :ok
+               assert Logger.info(send(self(), :something), []) == :ok
              end) == ""
+
+      refute_received :something
     end
 
     test "warning/2" do
@@ -374,8 +378,10 @@ defmodule LoggerTest do
              end) == ""
 
       assert capture_log(:error, fn ->
-               assert Logger.warning(raise("not invoked"), []) == :ok
+               assert Logger.warning(send(self(), :something), []) == :ok
              end) == ""
+
+      refute_received :something
     end
 
     test "error/2" do
@@ -388,8 +394,10 @@ defmodule LoggerTest do
              end) == ""
 
       assert capture_log(:critical, fn ->
-               assert Logger.error(raise("not invoked"), []) == :ok
+               assert Logger.error(send(self(), :something), []) == :ok
              end) == ""
+
+      refute_received :something
     end
 
     test "critical/2" do
@@ -402,8 +410,10 @@ defmodule LoggerTest do
              end) == ""
 
       assert capture_log(:alert, fn ->
-               assert Logger.critical(raise("not invoked"), []) == :ok
+               assert Logger.critical(send(self(), :something), []) == :ok
              end) == ""
+
+      refute_received :something
     end
 
     test "alert/2" do
@@ -416,8 +426,10 @@ defmodule LoggerTest do
              end) == ""
 
       assert capture_log(:emergency, fn ->
-               assert Logger.alert(raise("not invoked"), []) == :ok
+               assert Logger.alert(send(self(), :something), []) == :ok
              end) == ""
+
+      refute_received :something
     end
 
     test "emergency/2" do
@@ -430,8 +442,10 @@ defmodule LoggerTest do
              end) == ""
 
       assert capture_log(:none, fn ->
-               assert Logger.emergency(raise("not invoked"), []) == :ok
+               assert Logger.emergency(send(self(), :something), []) == :ok
              end) == ""
+
+      refute_received :something
     end
   end