You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Only occurs when mixing strings and URIs, but the docs seem to
encourage that.
Without the fix the test results in the following error:
```
1) test merge/2 (URITest)
test/elixir/uri_test.exs:376
** (KeyError) key :scheme not found in: "http://google.com/foo"
If you are using the dot syntax, such as map.field, make sure the left-hand side of the dot is a map
code: assert URI.merge("http://google.com/foo", URI.new!("//example.com/baz"))
stacktrace:
(elixir 1.18.0-dev) lib/uri.ex:911: URI.merge/2
test/elixir/uri_test.exs:390: (test)
```
That's because that (one) particular clause didn't check for the
base to be a `%URI{}`.
Happy to also backport it to the 1.17 branch (should be easy/
probably cherry-pickable) but:
1. seems like an extreme edge case
2. a workaround is available (use URI/URI or String/String as args)
0 commit comments