Skip to content

Commit 664396d

Browse files
committed
Remove improper_list/2
1 parent 5efcb4d commit 664396d

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

lib/elixir/lib/module/types/descr.ex

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,6 @@ defmodule Module.Types.Descr do
7676
def list(type), do: list_descr(type, @empty_list, true)
7777
def non_empty_list(type), do: list_descr(type, @empty_list, false)
7878
def non_empty_maybe_improper_list(type, tail), do: list_descr(type, tail, false)
79-
def improper_list(), do: improper_list(term(), term())
80-
def improper_list(type, :term), do: list_descr(type, @not_list, false)
81-
def improper_list(type, tail), do: list_descr(type, difference(tail, list(term())), false)
8279
def open_map(), do: %{map: @map_top}
8380
def open_map(pairs), do: map_descr(:open, pairs)
8481
def open_tuple(elements, _fallback \\ term()), do: tuple_descr(:open, elements)

lib/elixir/test/elixir/module/types/descr_test.exs

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1336,23 +1336,30 @@ defmodule Module.Types.DescrTest do
13361336
assert list(term(), term()) |> to_quoted_string() ==
13371337
"empty_list() or non_empty_maybe_improper_list(term(), term())"
13381338

1339-
assert improper_list(term(), term()) |> to_quoted_string() ==
1340-
"improper_list(term(), term())"
1339+
assert non_empty_maybe_improper_list(term(), term()) |> to_quoted_string() ==
1340+
"non_empty_maybe_improper_list(term(), term())"
13411341

1342-
assert improper_list(integer(), integer()) |> to_quoted_string() ==
1343-
"improper_list(integer(), integer())"
1342+
assert non_empty_maybe_improper_list(term(), difference(term(), empty_list()))
1343+
|> to_quoted_string() ==
1344+
"non_empty_maybe_improper_list(term(), term())"
1345+
1346+
assert non_empty_maybe_improper_list(integer(), integer()) |> to_quoted_string() ==
1347+
"non_empty_maybe_improper_list(integer(), integer())"
13441348

1345-
assert union(empty_list(), improper_list(integer(), integer())) |> to_quoted_string() ==
1346-
"empty_list() or improper_list(integer(), integer())"
1349+
assert union(empty_list(), non_empty_maybe_improper_list(integer(), integer()))
1350+
|> to_quoted_string() ==
1351+
"empty_list() or non_empty_maybe_improper_list(integer(), integer())"
13471352

1348-
assert union(non_empty_list(integer()), improper_list(integer(), integer()))
1353+
assert union(non_empty_list(integer()), non_empty_maybe_improper_list(integer(), integer()))
13491354
|> to_quoted_string() ==
13501355
"non_empty_maybe_improper_list(integer(), empty_list() or integer())"
13511356

1352-
assert union(list(integer()), improper_list(integer(), integer())) |> to_quoted_string() ==
1357+
assert union(list(integer()), non_empty_maybe_improper_list(integer(), integer()))
1358+
|> to_quoted_string() ==
13531359
"empty_list() or non_empty_maybe_improper_list(integer(), empty_list() or integer())"
13541360

1355-
assert union(list(term()), improper_list(term(), term())) |> to_quoted_string() ==
1361+
assert union(list(term()), non_empty_maybe_improper_list(term(), term()))
1362+
|> to_quoted_string() ==
13561363
"empty_list() or non_empty_maybe_improper_list(term(), term())"
13571364

13581365
# Test normalization

0 commit comments

Comments
 (0)