Skip to content

Commit 70be440

Browse files
committed
Only warn for commas at the end of words
1 parent c6d6683 commit 70be440

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

lib/elixir/lib/kernel.ex

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5388,7 +5388,8 @@ defmodule Kernel do
53885388
true ->
53895389
parts = String.split(string)
53905390

5391-
parts_with_trailing_comma = :lists.filter(&(:binary.last(&1) == ?,), parts)
5391+
parts_with_trailing_comma =
5392+
:lists.filter(&(byte_size(&1) > 1 and :binary.last(&1) == ?,), parts)
53925393

53935394
if parts_with_trailing_comma != [] do
53945395
stacktrace = Macro.Env.stacktrace(caller)

lib/elixir/test/elixir/kernel/sigils_test.exs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ bar) in ["foo\\\nbar", "foo\\\r\nbar"]
6666

6767
test "sigil w" do
6868
assert ~w() == []
69+
assert ~w([ , ]) == ["[", ",", "]"]
6970
assert ~w(foo bar baz) == ["foo", "bar", "baz"]
7071
assert ~w(foo #{:bar} baz) == ["foo", "bar", "baz"]
7172

@@ -100,6 +101,7 @@ bar) in ["foo\\\nbar", "foo\\\r\nbar"]
100101

101102
test "sigil W" do
102103
assert ~W() == []
104+
assert ~W([ , ]) == ["[", ",", "]"]
103105
assert ~W(foo #{bar} baz) == ["foo", "\#{bar}", "baz"]
104106

105107
assert ~W(foo\ bar) == ["foo\\", "bar"]

0 commit comments

Comments
 (0)