Skip to content

Commit 71eca8a

Browse files
author
José Valim
committed
Move from already_added to already_present
1 parent f0bb0e1 commit 71eca8a

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

lib/elixir/lib/gen_event.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ defmodule GenEvent do
315315
the event handler is ignored and this function returns `{:error, reason}`.
316316
317317
If the given handler was previously installed at the manager, this
318-
function returns `{:error, :already_added}`.
318+
function returns `{:error, :already_present}`.
319319
320320
## Monitored handlers
321321
@@ -960,7 +960,7 @@ defmodule GenEvent do
960960
{false, error, handlers}
961961
end
962962
_ ->
963-
{false, {:error, :already_added}, handlers}
963+
{false, {:error, :already_present}, handlers}
964964
end
965965
end
966966

@@ -979,7 +979,7 @@ defmodule GenEvent do
979979
server_add_handler(module2, {args2, state}, [])
980980
end
981981
else
982-
{false, {:error, :already_added}, []}
982+
{false, {:error, :already_present}, []}
983983
end
984984

985985
case res do

lib/elixir/test/elixir/gen_event_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ defmodule GenEventTest do
234234

235235
assert GenEvent.add_handler(pid, ReplyHandler, {:throw, self()}) == :ok
236236
assert GenEvent.which_handlers(pid) == [ReplyHandler]
237-
assert GenEvent.add_handler(pid, ReplyHandler, {:throw, self()}) == {:error, :already_added}
237+
assert GenEvent.add_handler(pid, ReplyHandler, {:throw, self()}) == {:error, :already_present}
238238

239239
assert GenEvent.add_handler(pid, {ReplyHandler, self()}, {self(), false}) == :ok
240240
assert GenEvent.which_handlers(pid) == [{ReplyHandler, self()}, ReplyHandler]
@@ -317,7 +317,7 @@ defmodule GenEventTest do
317317

318318
assert GenEvent.add_handler(pid, ReplyHandler, {self(), false}) == :ok
319319
assert GenEvent.swap_handler(pid, ReplyHandler, :swapped,
320-
{ReplyHandler, self()}, :swap) == {:error, :already_added}
320+
{ReplyHandler, self()}, :swap) == {:error, :already_present}
321321
assert GenEvent.which_handlers(pid) == [{ReplyHandler, self()}]
322322

323323
assert GenEvent.remove_handler(pid, {ReplyHandler, self()}, :remove_handler) ==

lib/logger/test/logger_test.exs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ defmodule LoggerTest do
4242

4343
assert {:ok, _pid} = Logger.add_backend(:console)
4444
assert Application.get_env(:logger, :backends) == [:console]
45-
assert Logger.add_backend(:console) == {:error, :already_added}
45+
assert Logger.add_backend(:console) == {:error, :already_present}
4646
assert Application.get_env(:logger, :backends) == [:console]
4747
end
4848

@@ -56,7 +56,7 @@ defmodule LoggerTest do
5656
end
5757

5858
assert {:ok, _} = Logger.add_backend({MyBackend, :hello})
59-
assert {:error, :already_added} = Logger.add_backend({MyBackend, :hello})
59+
assert {:error, :already_present} = Logger.add_backend({MyBackend, :hello})
6060
assert :ok = Logger.remove_backend({MyBackend, :hello})
6161
end
6262

@@ -195,7 +195,7 @@ defmodule LoggerTest do
195195

196196
assert {:ok, pid} = Logger.add_backend(:console)
197197
assert Logger.add_backend(:console) ==
198-
{:error, :already_added}
198+
{:error, :already_present}
199199
after
200200
Application.put_env(:logger, :backends, [:console])
201201
Logger.App.stop()

0 commit comments

Comments
 (0)