Skip to content

Commit 8047f3d

Browse files
committed
Down to 3 failures
1 parent f8c6054 commit 8047f3d

File tree

4 files changed

+6
-18
lines changed

4 files changed

+6
-18
lines changed

lib/mix/lib/mix.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1077,7 +1077,7 @@ defmodule Mix do
10771077
app: @mix_install_app,
10781078
erlc_paths: [],
10791079
elixirc_paths: [],
1080-
compilers: [],
1080+
compilers: [:elixir],
10811081
prune_code_paths: false
10821082
] ++ dynamic_config
10831083
end

lib/mix/lib/mix/tasks/compile.elixir.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ defmodule Mix.Tasks.Compile.Elixir do
130130
# TODO: Deprecate me on Elixir v1.23
131131
Keyword.put(opts, :consolidate_protocols, false)
132132
else
133-
opts
133+
opts ++ Keyword.take(project, [:consolidate_protocols])
134134
end
135135

136136
# Having compilations racing with other is most undesired,

lib/mix/test/mix/tasks/compile.elixir_test.exs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1315,6 +1315,7 @@ defmodule Mix.Tasks.Compile.ElixirTest do
13151315
assert Mix.Tasks.Compile.Elixir.run(["--verbose"]) == {:ok, []}
13161316
assert_received {:mix_shell, :info, ["Compiling 1 file (.ex)"]}
13171317
assert_received {:mix_shell, :info, ["Compiled lib/a.ex"]}
1318+
Mix.shell().flush()
13181319

13191320
File.rm!("lib/a.ex")
13201321
assert Mix.Tasks.Compile.Elixir.run(["--verbose"]) == {:ok, []}

lib/mix/test/mix/tasks/compile_test.exs

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -55,22 +55,9 @@ defmodule Mix.Tasks.CompileTest do
5555
assert_received {:mix_shell, :info, ["Generated sample app"]}
5656
assert File.regular?("_build/dev/lib/sample/consolidated/Elixir.Enumerable.beam")
5757

58-
# Noop
5958
Mix.Task.clear()
6059
assert Mix.Task.run("compile", ["--verbose"]) == {:noop, []}
6160
refute_received {:mix_shell, :info, ["Compiled lib/a.ex"]}
62-
63-
# Consolidates protocols if manifest is out of date
64-
File.rm("_build/dev/lib/sample/.mix/compile.protocols")
65-
Mix.Task.clear()
66-
assert Mix.Task.run("compile", ["--verbose"]) == {:ok, []}
67-
refute_received {:mix_shell, :info, ["Compiled lib/a.ex"]}
68-
assert File.regular?("_build/dev/lib/sample/consolidated/Elixir.Enumerable.beam")
69-
70-
# Purge so consolidated is picked up
71-
purge([Enumerable])
72-
assert Mix.Tasks.App.Start.run(["--verbose"]) == :ok
73-
assert Protocol.consolidated?(Enumerable)
7461
end)
7562
end
7663

@@ -224,10 +211,10 @@ defmodule Mix.Tasks.CompileTest do
224211
end)
225212
end
226213

227-
test "skip protocol consolidation when --no-consolidate-protocols" do
214+
test "skip protocol consolidation when --no-protocol-consolidation" do
228215
in_fixture("no_mixfile", fn ->
229216
File.rm("_build/dev/lib/sample/.mix/compile.protocols")
230-
assert Mix.Task.run("compile", ["--no-consolidate-protocols"]) == {:ok, []}
217+
assert Mix.Task.run("compile", ["--no-protocol-consolidation"]) == {:ok, []}
231218
assert File.regular?("_build/dev/lib/sample/ebin/Elixir.A.beam")
232219
refute File.regular?("_build/dev/lib/sample/consolidated/Elixir.Enumerable.beam")
233220
end)
@@ -283,7 +270,7 @@ defmodule Mix.Tasks.CompileTest do
283270
Mix.Project.push(WrongPath)
284271

285272
ExUnit.CaptureIO.capture_io(fn ->
286-
assert Mix.Task.run("compile", ["--no-consolidate-protocols"]) == {:noop, []}
273+
assert Mix.Task.run("compile", ["--no-protocol-consolidation"]) == {:noop, []}
287274
end)
288275
end
289276

0 commit comments

Comments
 (0)