Deprecate Record.import/2

This is part of the preparation for maps.

Author: José Valim

lib/elixir/lib/record.ex

@@ -224,6 +224,8 @@ defmodule Record do
 
   """
   defmacro import(module, as: name) do
+    IO.write :stderr, "Record.import/2 is deprecated and it will be removed in the following releases\n#{Exception.format_stacktrace}"
+
     quote do
       module = unquote(module)
 
@@ -509,7 +511,7 @@ defmodule Record do
   # converting record to keywords list.
   @doc false
   def to_keywords(name, _atom, fields, record, caller) do
-    IO.write "#{name}(record) for private records returning a keyword list is deprecated\n#{Exception.format_stacktrace(caller.stacktrace)}"
+    IO.write :stderr, "#{name}(record) for private records returning a keyword list is deprecated\n#{Exception.format_stacktrace(caller.stacktrace)}"
     { var, extra } = cache_var(record)
 
     keywords = Enum.map fields,
@@ -531,12 +533,12 @@ defmodule Record do
   def dispatch(name, atom, fields, record, args, caller) do
     cond do
       is_atom(args) ->
-        IO.write "#{name}(record, field) for private records for retrieving a field is deprecated, please use pattern match instead\n#{Exception.format_stacktrace(caller.stacktrace)}"
+        IO.write :stderr, "#{name}(record, field) for private records for retrieving a field is deprecated, please use pattern match instead\n#{Exception.format_stacktrace(caller.stacktrace)}"
         get(atom, fields, record, args)
       is_keyword(args) ->
         update(atom, fields, record, args, caller)
       is_list(args) ->
-        IO.write "#{name}(record, fields) for private records for retrieving a list of fields is deprecated, please use pattern match instead\n#{Exception.format_stacktrace(caller.stacktrace)}"
+        IO.write :stderr, "#{name}(record, fields) for private records for retrieving a list of fields is deprecated, please use pattern match instead\n#{Exception.format_stacktrace(caller.stacktrace)}"
         to_list(atom, fields, record, args)
       true ->
         raise ArgumentError, message: "expected arguments to be a compile time atom, list or keywords"

lib/elixir/test/elixir/record_test.exs

@@ -6,18 +6,6 @@ defrecord RecordTest.FileInfo,
 defrecord RecordTest.SomeRecord, a: 0, b: &Dict.get/2
 defrecord RecordTest.WithNoField, []
 
-## Record import
-
-defmodule RecordTest.FileInfo.Helper do
-  Record.import RecordTest.FileInfo, as: :file_info
-
-  def new do
-    file_info
-  end
-
-  def size(file_info(size: size)), do: size
-end
-
 ## Dynamic names and overridable
 
 name = RecordTest.DynamicName
@@ -27,8 +15,6 @@ defrecord name, a: 0, b: 1 do
   def update_b(_, _) do
     :not_optimizable
   end
-
-  Record.import __MODULE__, as: :self
 end
 
 defmodule RecordTest.DynamicOpts do
@@ -162,11 +148,6 @@ defmodule RecordTest do
     end)
   end
 
-  test :import do
-    assert RecordTest.FileInfo.Helper.new == RecordTest.FileInfo.new
-    assert RecordTest.FileInfo.Helper.size(RecordTest.FileInfo.new(size: 100)) == 100
-  end
-
   test :record_with_functions_as_defaults do
     defrecord WithFun, fun: [&Kernel.is_atom/1]
     assert WithFun.new.fun == [&Kernel.is_atom/1]