Skip to content

Commit 865b315

Browse files
Apply suggestions from code review
Co-authored-by: Zach Allaun <[email protected]>
1 parent e85bc85 commit 865b315

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

lib/elixir/lib/code.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1639,8 +1639,8 @@ defmodule Code do
16391639
* `:ignore_module_conflict` - when `true`, does not warn when a module has
16401640
already been defined. Defaults to `false`.
16411641
1642-
* `:infer_signatures` (since v1.18.0) - when `false`, it disables inference
1643-
module-local signatures used when type checking remote calls to the compiled
1642+
* `:infer_signatures` (since v1.18.0) - when `false`, it disables module-local
1643+
signature inference used when type checking remote calls to the compiled
16441644
module. Type checking it still executed. Defaults to `true`.
16451645
16461646
* `:relative_paths` - when `true`, uses relative paths in quoted nodes,

lib/elixir/lib/module/types/of.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,8 +1081,8 @@ defmodule Module.Types.Of do
10811081
"""
10821082
the #{integer_to_ordinal(i + 1)} argument is empty (often represented as none()), \
10831083
most likely because it is the result of an expression that always fails, such as \
1084-
a `raise` or a previous invalid call. This causes any subsequent function call with \
1085-
said value to always fail
1084+
a `raise` or a previous invalid call. This causes any function called with this \
1085+
value to fail
10861086
"""
10871087
else
10881088
"""
@@ -1294,7 +1294,7 @@ defmodule Module.Types.Of do
12941294
end
12951295

12961296
defp integer_to_ordinal(i) do
1297-
case rem(i, 10) in [1, 2, 3] do
1297+
case rem(i, 10) do
12981298
1 when rem(i, 100) != 11 -> "#{i}st"
12991299
2 when rem(i, 100) != 12 -> "#{i}nd"
13001300
3 when rem(i, 100) != 13 -> "#{i}rd"

lib/elixir/test/elixir/module/types/expr_test.exs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,11 +176,10 @@ defmodule Module.Types.ExprTest do
176176
177177
none()
178178
179-
the 1th argument is empty (often represented as none()), \
179+
the 1st argument is empty (often represented as none()), \
180180
most likely because it is the result of an expression that \
181181
always fails, such as a `raise` or a previous invalid call. \
182-
This causes any subsequent function call with said value \
183-
to always fail
182+
This causes any function called with this value to fail
184183
"""
185184
end
186185

0 commit comments

Comments
 (0)