Skip to content

Commit 8bec593

Browse files
christhekeelejosevalim
authored andcommitted
Ensure unconstrained rebar deps generate valid mix specifications (#11063)
1 parent 03859fb commit 8bec593

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

lib/mix/lib/mix/rebar.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ defmodule Mix.Rebar do
123123
# Translate a Rebar dependency declaration to a Mix declaration
124124
# From http://www.rebar3.org/docs/dependencies#section-declaring-dependencies
125125
defp parse_dep(app) when is_atom(app) do
126-
{app, nil, override: true}
126+
{app, override: true}
127127
end
128128

129129
defp parse_dep({app, req}) when is_list(req) do

lib/mix/test/mix/rebar_test.exs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,8 @@ defmodule Mix.RebarTest do
112112

113113
assert parse_dep({:git_rebar, '', {:git, @git_rebar_charlist, {:ref, '64691eb'}}}) ==
114114
{:git_rebar, ~r"", override: true, git: @git_rebar_string, ref: "64691eb"}
115+
116+
assert parse_dep(:git_rebar) == {:git_rebar, override: true}
115117
end
116118
end
117119

0 commit comments

Comments
 (0)