Fix opaqueness violation in Task.Supervisor

Author: sabiwara

lib/elixir/lib/task.ex

@@ -1450,7 +1450,10 @@ defmodule Task do
     :erlang.monitor(:process, pid)
   end
 
-  defp build_alias(pid) do
+  # exported only to avoid dialyzer opaqueness check in internal Task modules
+  @doc false
+  @spec build_alias(pid()) :: Task.ref()
+  def build_alias(pid) do
     :erlang.monitor(:process, pid, alias: :demonitor)
   end
 

lib/elixir/lib/task/supervisor.ex

@@ -614,7 +614,7 @@ defmodule Task.Supervisor do
     case start_child_with_spec(supervisor, [get_owner(owner), :monitor], :temporary, shutdown) do
       {:ok, pid} ->
         if link_type == :link, do: Process.link(pid)
-        alias = :erlang.monitor(:process, pid, alias: :demonitor)
+        alias = Task.build_alias(pid)
         send(pid, {owner, alias, alias, get_callers(owner), {module, fun, args}})
         %Task{pid: pid, ref: alias, owner: owner, mfa: {module, fun, length(args)}}
 

lib/elixir/test/elixir/fixtures/dialyzer/opaque_inline.ex

@@ -0,0 +1,17 @@
+defmodule Dialyzer.Opaqueness do
+  @spec bar(MapSet.t()) :: term()
+  def bar(set) do
+    set
+  end
+
+  def foo() do
+    # inlining of literals should not violate opaqueness check
+    bar(MapSet.new([1, 2, 3]))
+  end
+
+  # Task.Supervisor returns a Task.t() containing an opaque Task.ref()
+  @spec run_task() :: Task.t()
+  def run_task do
+    Task.Supervisor.async(SupervisorName, fn -> :ok end)
+  end
+end

lib/elixir/test/elixir/fixtures/dialyzer/opaqueness.ex

@@ -50,7 +50,9 @@ defmodule Kernel.DialyzerTest do
       Module,
       Protocol,
       String,
-      String.Chars
+      String.Chars,
+      Task,
+      Task.Supervisor
     ]
 
     files = Enum.map(mods, &:code.which/1)
@@ -178,8 +180,8 @@ defmodule Kernel.DialyzerTest do
     assert_dialyze_no_warnings!(context)
   end
 
-  test "no warning on inlined calls returning opaque", context do
-    copy_beam!(context, Dialyzer.OpaqueInline)
+  test "no warning due to opaqueness edge cases", context do
+    copy_beam!(context, Dialyzer.Opaqueness)
     assert_dialyze_no_warnings!(context)
   end