Merge pull request #1716 from ericmj/mix-deps-compile-false

Fix `compile: false` dependency option

Author: José Valim

lib/mix/lib/mix/tasks/deps.compile.ex

@@ -53,7 +53,9 @@ defmodule Mix.Tasks.Deps.Compile do
         Mix.Dep[app: app, status: status, opts: opts] = dep
 
         check_unavailable!(app, status)
-        unless run_opts[:quiet], do: shell.info "* Compiling #{app}"
+        unless run_opts[:quiet] || opts[:compile] == false do
+          shell.info "* Compiling #{app}"
+        end
 
         deps_path = opts[:dest]
         root_path = Path.expand(Mix.project[:deps_path])
@@ -69,12 +71,17 @@ defmodule Mix.Tasks.Deps.Compile do
         Enum.each ebins, fn ebin -> :code.del_path(ebin |> Path.expand) end
 
         compiled = cond do
-          opts[:compile] -> File.cd! deps_path, fn -> do_compile app, opts[:compile] end
-          mix?(dep)      -> File.cd! deps_path, fn -> do_mix dep, config end
-          rebar?(dep)    -> File.cd! deps_path, fn -> do_rebar app, root_path end
-          make?(dep)     -> File.cd! deps_path, fn -> do_command app, "make" end
-          true           -> shell.error "Could not compile #{app}, no mix.exs, rebar.config or Makefile " <>
-                              "(pass :compile as an option to customize compilation, set it to :noop to do nothing)"
+          not nil?(opts[:compile]) ->
+            File.cd! deps_path, fn -> do_compile app, opts[:compile] end
+          mix?(dep) ->
+            File.cd! deps_path, fn -> do_mix dep, config end
+          rebar?(dep) ->
+            File.cd! deps_path, fn -> do_rebar app, root_path end
+          make?(dep) ->
+            File.cd! deps_path, fn -> do_command app, "make" end
+          true ->
+            shell.error "Could not compile #{app}, no mix.exs, rebar.config or Makefile " <>
+              "(pass :compile as an option to customize compilation, set it to false to do nothing)"
         end
 
         Enum.each ebins, &Code.prepend_path/1

lib/mix/test/mix/tasks/deps_test.exs

@@ -443,4 +443,29 @@ defmodule Mix.Tasks.DepsTest do
   after
     Mix.Project.pop
   end
+
+  defmodule NonCompilingDeps do
+    def project do
+      [
+        app: :raw_sample,
+        version: "0.1.0",
+        deps: [
+          { :deps_repo, "0.1.0", path: "custom/deps_repo", compile: false },
+          { :git_repo, "0.1.0", git: MixTest.Case.fixture_path("git_repo"), compile: false }
+        ]
+      ]
+    end
+  end
+
+  test "dont compile deps" do
+    Mix.Project.push NonCompilingDeps
+
+    in_fixture "deps_status", fn ->
+      Mix.Tasks.Deps.Compile.run []
+      refute_received { :mix_shell, :info, ["* Compiling deps_repo"] }
+      refute_received { :mix_shell, :info, ["* Compiling git_repo"] }
+    end
+  after
+    Mix.Project.pop
+  end
 end