Apply code review suggestions

Author: Papipo

lib/mix/lib/mix/tasks/compile.app.ex

@@ -281,7 +281,9 @@ defmodule Mix.Tasks.Compile.App do
 
   defp merge_project_application(best_guess, _project, application) do
     if not Keyword.keyword?(application) do
-      Mix.raise("Application configuration passed as :application should be a keyword list")
+      Mix.raise(
+        "Application configuration passed as :application should be a keyword list, , got: #{inspect(application)}"
+      )
     end
 
     Keyword.merge(best_guess, validate_properties!(application))

lib/mix/lib/mix/tasks/deps.compile.ex

@@ -342,6 +342,13 @@ defmodule Mix.Tasks.Deps.Compile do
     src = Path.join(build, "_gleam_artefacts")
     File.mkdir(Path.join(build, "ebin"))
 
+    # Remove per-environment segment from the path since ProjectStack.push below will append it
+    build_path =
+      Mix.Project.build_path()
+      |> Path.split()
+      |> Enum.drop(-1)
+      |> Path.join()
+
     config =
       Mix.Project.deps_config()
       |> Keyword.merge(
@@ -350,8 +357,7 @@ defmodule Mix.Tasks.Deps.Compile do
         deps: toml.deps,
         build_per_environment: true,
         lockfile: "mix.lock",
-        # Remove per-environment segment from the path since ProjectStack.push below will append it
-        build_path: Mix.Project.build_path() |> Path.split() |> Enum.drop(-1) |> Path.join(),
+        build_path: build_path,
         build_scm: dep.scm,
         deps_path: deps_path,
         deps_app_path: build,
@@ -360,10 +366,10 @@ defmodule Mix.Tasks.Deps.Compile do
         erlc_include_path: Path.join(build, "include")
       )
 
-    env = dep.opts[:env] || :prod
     old_env = Mix.env()
 
     try do
+      env = dep.opts[:env] || :prod
       Mix.env(env)
       Mix.ProjectStack.push(dep.app, config, "nofile")
 

lib/mix/test/fixtures/gleam_dep/.gitignore

@@ -1,7 +1,7 @@
 # The directory Mix will write compiled artifacts to.
 /_build/
 
-# The directory gleam will write compiled artifacts to.
+# The directory Gleam will write compiled artifacts to.
 /build/
 
 # If the VM crashes, it generates a dump, let's ignore it too.

lib/mix/test/fixtures/subfolder/deeper_gleam_dep/.gitignore

@@ -1,7 +1,7 @@
 # The directory Mix will write compiled artifacts to.
 /_build/
 
-# The directory gleam will write compiled artifacts to.
+# The directory Gleam will write compiled artifacts to.
 /build/
 
 # If the VM crashes, it generates a dump, let's ignore it too.