Add @doc false to each gen* callback by default

Author: José Valim

lib/elixir/lib/application/behaviour.ex

@@ -48,7 +48,6 @@ defmodule Application.Behaviour do
 
   """
 
-
   # Starts the given application and all of its dependencies that
   # have not been started yet recursively.
   #
@@ -95,6 +94,7 @@ defmodule Application.Behaviour do
     quote location: :keep do
       @behavior :application
 
+      @doc false
       def stop(_state) do
         :ok
       end

lib/elixir/lib/gen_event/behaviour.ex

@@ -55,28 +55,34 @@ defmodule GenEvent.Behaviour do
   @doc false
   defmacro __using__(_) do
     quote location: :keep do
-      @behavior :gen_event
+      @behaviour :gen_event
 
+      @doc false
       def init(args) do
         { :ok, args }
       end
 
+      @doc false
       def handle_event(_event, state) do
         { :ok, state }
       end
 
+      @doc false
       def handle_call(_request, state) do
         { :ok, :ok, state }
       end
 
+      @doc false
       def handle_info(_msg, state) do
         { :ok, state }
       end
 
+      @doc false
       def terminate(reason, state) do
         :ok
       end
 
+      @doc false
       def code_change(_old, state, _extra) do
         { :ok, state }
       end

lib/elixir/lib/gen_server/behaviour.ex

@@ -88,26 +88,32 @@ defmodule GenServer.Behaviour do
     quote location: :keep do
       @behavior :gen_server
 
+      @doc false
       def init(args) do
         { :ok, args }
       end
 
+      @doc false
       def handle_call(_request, _from, state) do
         { :noreply, state }
       end
 
+      @doc false
       def handle_info(_msg, state) do
         { :noreply, state }
       end
 
+      @doc false
       def handle_cast(_msg, state) do
         { :noreply, state }
       end
 
+      @doc false
       def terminate(_reason, _state) do
         :ok
       end
 
+      @doc false
       def code_change(_old, state, _extra) do
         { :ok, state }
       end

lib/elixir/lib/module.ex

@@ -216,17 +216,15 @@ defmodule Module do
       [] ->
         ETS.insert(table, { tuple, line, kind, signature, doc })
         :ok
-      [{ tuple, line, _old_kind, old_sign, old_doc }] when old_doc == nil or doc == nil or old_doc == doc ->
+      [{ tuple, line, _old_kind, old_sign, old_doc }] ->
         ETS.insert(table, {
           tuple,
           line,
           kind,
           merge_signatures(old_sign, signature, 1),
-          doc || old_doc
+          if(nil?(doc), do: old_doc, else: doc)
         })
         :ok
-      _ ->
-        { :error, :existing_doc }
     end
   end
 
@@ -556,8 +554,6 @@ defmodule Module do
         :ok
       { :error, :private_doc } ->
         IO.puts "#{env.file}:#{line} function #{name}/#{arity} is private, @doc's are always discarded for private functions"
-      { :error, :existing_doc } ->
-        IO.puts "#{env.file}:#{line} @doc's for function #{name}/#{arity} have been given more than once, the first version is being kept"
     end
 
     delete_attribute(module, :doc)