add user as suffix to mix_pubsub and mix_lock paths

Author: SteffenDE

lib/mix/lib/mix/sync/lock.ex

@@ -97,9 +97,7 @@ defmodule Mix.Sync.Lock do
     opts = Keyword.validate!(opts, [:on_taken])
 
     hash = key |> :erlang.md5() |> Base.url_encode64(padding: false)
-    base_path = Path.join([System.tmp_dir!(), "mix_lock"])
-    init_base_path(base_path)
-    path = Path.join([base_path, hash])
+    path = Path.join(base_path(), hash)
 
     pdict_key = {__MODULE__, path}
     has_lock? = Process.get(pdict_key, false)
@@ -121,10 +119,11 @@ defmodule Mix.Sync.Lock do
     end
   end
 
-  defp init_base_path(path) do
+  defp base_path do
+    user = System.get_env("USER", "default")
+    path = Path.join([System.tmp_dir!(), "mix_pubsub_#{Base.url_encode64(user, padding: false)}"])
     File.mkdir_p!(path)
-    # ensure other users can write to the directory
-    _ = File.chmod(path, 0o777)
+    path
   end
 
   defp lock_disabled?(), do: System.get_env("MIX_OS_CONCURRENCY_LOCK") in ~w(0 false)

lib/mix/lib/mix/sync/pubsub.ex

@@ -127,7 +127,6 @@ defmodule Mix.Sync.PubSub do
   @impl true
   def init({}) do
     state = %{port: nil, hash_to_pids: %{}}
-    init_base_path()
     {:ok, state}
   end
 
@@ -274,19 +273,15 @@ defmodule Mix.Sync.PubSub do
   defp hash(key), do: :erlang.md5(key)
 
   defp base_path do
-    Path.join(System.tmp_dir!(), "mix_pubsub")
+    user = System.get_env("USER", "default")
+    path = Path.join([System.tmp_dir!(), "mix_lock_#{Base.url_encode64(user, padding: false)}"])
+    File.mkdir_p!(path)
+    path
   end
 
   defp path(hash) do
     hash = Base.url_encode64(hash, padding: false)
-    Path.join([base_path(), hash])
-  end
-
-  defp init_base_path do
-    path = base_path()
-    File.mkdir_p!(path)
-    # ensure other users can write to the directory
-    _ = File.chmod(path, 0o777)
+    Path.join(base_path(), hash)
   end
 
   defp recv(socket, size, timeout \\ :infinity) do