Rename :application to Application and remove unused fixtures

Author: José Valim

lib/elixir/lib/kernel/cli.ex

@@ -278,7 +278,7 @@ defmodule Kernel.CLI do
   end
 
   defp process_command({:app, app}, _config) when is_binary(app) do
-    case :application.ensure_all_started(binary_to_atom(app)) do
+    case Application.ensure_all_started(binary_to_atom(app)) do
       {:error, {app, reason}} ->
         {:error, "--app : Could not start application #{app}: " <>
           Application.format_reason(reason)}

lib/elixir/lib/uri.ex

@@ -45,16 +45,20 @@ defmodule URI do
 
   """
   def default_port(scheme) when is_binary(scheme) do
-    {:ok, dict} = :application.get_env(:elixir, :uri)
+    {:ok, dict} = Application.fetch_env(:elixir, :uri)
     Map.get(dict, scheme)
   end
 
   @doc """
   Registers a scheme with a default port.
+
+  It is recommended for this function to be invoked in your
+  application start callback in case you want to register
+  new URIs.
   """
   def default_port(scheme, port) when is_binary(scheme) and port > 0 do
-    {:ok, dict} = :application.get_env(:elixir, :uri)
-    :application.set_env(:elixir, :uri, Map.put(dict, scheme, port))
+    {:ok, dict} = Application.fetch_env(:elixir, :uri)
+    Application.put_env(:elixir, :uri, Map.put(dict, scheme, port), persist: true)
   end
 
   @doc """

lib/elixir/test/elixir/inspect_test.exs

@@ -330,20 +330,20 @@ defmodule Inspect.OthersTest do
       end
     end
 
-    :application.set_env(:elixir, :anony, V.fun)
-    :application.set_env(:elixir, :named, &V.fun/0)
+    Application.put_env(:elixir, :anony, V.fun)
+    Application.put_env(:elixir, :named, &V.fun/0)
 
     :code.delete(V)
     :code.purge(V)
 
-    {:ok, anony} = :application.get_env(:elixir, :anony)
-    {:ok, named} = :application.get_env(:elixir, :named)
+    anony = Application.get_env(:elixir, :anony)
+    named = Application.get_env(:elixir, :named)
 
     assert inspect(anony) =~ ~r"#Function<0.\d+/0 in Inspect.OthersTest.V>"
     assert inspect(named) =~ ~r"&Inspect.OthersTest.V.fun/0"
   after
-    :application.unset_env(:elixir, :anony)
-    :application.unset_env(:elixir, :named)
+    Application.delete_env(:elixir, :anony)
+    Application.delete_env(:elixir, :named)
   end
 
   test :other_funs do

lib/ex_unit/lib/ex_unit.ex

@@ -114,13 +114,13 @@ defmodule ExUnit do
   If you want to run tests manually, you can set `:autorun` to `false`.
   """
   def start(options \\ []) do
-    :application.start(:elixir)
-    :application.start(:ex_unit)
+    Application.start(:elixir)
+    Application.start(:ex_unit)
 
     configure(options)
 
-    if :application.get_env(:ex_unit, :autorun) != {:ok, false} do
-      :application.set_env(:ex_unit, :autorun, false)
+    if Application.get_env(:ex_unit, :autorun, true) do
+      Application.put_env(:ex_unit, :autorun, false)
 
       System.at_exit fn
         0 ->

lib/iex/lib/iex/options.ex

@@ -53,7 +53,7 @@ defmodule IEx.Options do
 
   for key <- @supported_options do
     def get(unquote(key)) do
-      {:ok, value} = :application.get_env(:iex, unquote(key))
+      {:ok, value} = Application.fetch_env(:iex, unquote(key))
       value
     end
   end
@@ -102,7 +102,7 @@ defmodule IEx.Options do
 
   def set(:history_size, size) when is_integer(size) do
     old_size = get(:history_size)
-    :application.set_env(:iex, :history_size, size)
+    Application.put_env(:iex, :history_size, size)
     old_size
   end
 

lib/mix/lib/mix.ex

@@ -15,8 +15,8 @@ defmodule Mix do
 
   @doc false
   def start do
-    :application.start(:elixir)
-    :application.start(:mix)
+    Application.start(:elixir)
+    Application.start(:mix)
   end
 
   @doc false
@@ -32,11 +32,8 @@ defmodule Mix do
   Returns the mix environment.
   """
   def env do
-    # env is not available on bootstrapping
-    case :application.get_env(:mix, :env) do
-      {:ok, env} -> env
-      :undefined -> :dev
-    end
+    # env is not available on bootstrapping, so set a :dev default
+    Application.get_env(:mix, :env, :dev)
   end
 
   @doc """
@@ -46,7 +43,7 @@ defmodule Mix do
   configuration won't be reloaded.
   """
   def env(env) when is_atom(env) do
-    :application.set_env(:mix, :env, env)
+    Application.put_env(:mix, :env, env)
   end
 
   @doc """
@@ -58,17 +55,14 @@ defmodule Mix do
   messages to the current process.
   """
   def shell do
-    case :application.get_env(:mix, :shell) do
-      {:ok, shell} -> shell
-      :undefined -> Mix.Shell.IO
-    end
+    Application.get_env(:mix, :shell, Mix.Shell.IO)
   end
 
   @doc """
   Sets the current shell.
   """
   def shell(shell) do
-    :application.set_env(:mix, :shell, shell)
+    Application.put_env(:mix, :shell, shell)
   end
 
   @doc false

lib/mix/lib/mix/remote_converger.ex

@@ -30,16 +30,13 @@ defmodule Mix.RemoteConverger do
   Get registered remote converger.
   """
   def get do
-    case :application.get_env(:mix, :remote_converger) do
-      {:ok, converger} -> converger
-      :undefined -> nil
-    end
+    Application.get_env(:mix, :remote_converger)
   end
 
   @doc """
   Register a remote converger.
   """
   def register(mod) when is_atom(mod) do
-    :application.set_env(:mix, :remote_converger, mod)
+    Application.put_env(:mix, :remote_converger, mod)
   end
 end

lib/mix/lib/mix/scm.ex

@@ -110,7 +110,7 @@ defmodule Mix.SCM do
   until a matching one is found.
   """
   def available do
-    {:ok, scm} = :application.get_env(:mix, :scm)
+    {:ok, scm} = Application.fetch_env(:mix, :scm)
     scm
   end
 
@@ -119,14 +119,14 @@ defmodule Mix.SCM do
   """
   def prepend(mod) when is_atom(mod) do
     available = Enum.reject(available(), &(&1 == mod))
-    :application.set_env(:mix, :scm, [mod|available])
+    Application.put_env(:mix, :scm, [mod|available])
   end
 
   @doc """
   Aopend the given SCM module to the list of available SCMs.
   """
   def append(mod) when is_atom(mod) do
     available = Enum.reject(available(), &(&1 == mod))
-    :application.set_env(:mix, :scm, available ++ [mod])
+    Application.put_env(:mix, :scm, available ++ [mod])
   end
 end

lib/mix/lib/mix/scm/git.ex

@@ -159,17 +159,17 @@ defmodule Mix.SCM.Git do
   end
 
   defp git_version do
-    case :application.get_env(:mix, :git_version) do
+    case Application.fetch_env(:mix, :git_version) do
       {:ok, version} ->
         version
-      :undefined ->
+      :error ->
         "git version " <> version = String.strip System.cmd("git --version")
         version = String.split(version, ".")
                   |> Enum.take(3)
                   |> Enum.map(&binary_to_integer(&1))
                   |> list_to_tuple
 
-        :application.set_env(:mix, :git_version, version)
+        Application.put_env(:mix, :git_version, version)
         version
     end
   end

lib/mix/lib/mix/tasks/app.start.ex

@@ -34,7 +34,7 @@ defmodule Mix.Tasks.App.Start do
   @doc false
   def start(app) do
     if app do
-      case :application.ensure_all_started(app) do
+      case Application.ensure_all_started(app) do
         {:ok, _} -> :ok
         {:error, {app, reason}} ->
           raise Mix.Error, message: "Could not start application #{app}: " <>