Skip to content

Commit a5b4c1c

Browse files
author
José Valim
committed
Document and test Logger functions return :ok
1 parent e38f960 commit a5b4c1c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

lib/logger/lib/logger.ex

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ defmodule Logger do
235235
def metadata(dict) do
236236
{enabled, metadata} = __metadata__()
237237
Process.put(@metadata, {enabled, Keyword.merge(metadata, dict)})
238+
:ok
238239
end
239240

240241
@doc """
@@ -251,6 +252,7 @@ defmodule Logger do
251252
"""
252253
def enable(pid) when pid == self() do
253254
Process.put(@metadata, {true, metadata()})
255+
:ok
254256
end
255257

256258
@doc """
@@ -260,6 +262,7 @@ defmodule Logger do
260262
"""
261263
def disable(pid) when pid == self() do
262264
Process.put(@metadata, {false, metadata()})
265+
:ok
263266
end
264267

265268
@doc """

lib/logger/test/logger_test.exs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,25 +65,25 @@ defmodule LoggerTest do
6565
end
6666

6767
test "enable/1 and disable/1" do
68-
Logger.metadata([])
68+
assert Logger.metadata([]) == :ok
6969

7070
assert capture_log(fn ->
7171
assert Logger.debug("hello", []) == :ok
7272
end) =~ msg("[debug] hello")
7373

74-
Logger.disable(self())
74+
assert Logger.disable(self()) == :ok
7575

7676
assert capture_log(fn ->
7777
assert Logger.debug("hello", []) == :ok
7878
end) == ""
7979

80-
Logger.metadata([])
80+
assert Logger.metadata([]) == :ok
8181

8282
assert capture_log(fn ->
8383
assert Logger.debug("hello", []) == :ok
8484
end) == ""
8585

86-
Logger.enable(self())
86+
assert Logger.enable(self()) == :ok
8787

8888
assert capture_log(fn ->
8989
assert Logger.debug("hello", []) == :ok

0 commit comments

Comments
 (0)