Skip to content

Commit a8959f3

Browse files
committed
Fix Version.match? with ~> and -dev versions
1 parent bce9116 commit a8959f3

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lib/elixir/lib/version.ex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -404,16 +404,16 @@ defmodule Version do
404404
defp approximate(version) do
405405
Version.from_matchable(case Regex.run(@version_regex, version) do
406406
[_, major] ->
407-
{ binary_to_integer(major) + 1, 0, 0, [] }
407+
{ binary_to_integer(major) + 1, 0, 0, [0] }
408408

409409
[_, major, _] ->
410-
{ binary_to_integer(major) + 1, 0, 0, [] }
410+
{ binary_to_integer(major) + 1, 0, 0, [0] }
411411

412412
[_, major, minor, _] ->
413-
{ binary_to_integer(major), binary_to_integer(minor) + 1, 0, [] }
413+
{ binary_to_integer(major), binary_to_integer(minor) + 1, 0, [0] }
414414

415415
[_, major, minor, _, _] ->
416-
{ binary_to_integer(major), binary_to_integer(minor) + 1, 0, [] }
416+
{ binary_to_integer(major), binary_to_integer(minor) + 1, 0, [0] }
417417
end)
418418
end
419419

lib/elixir/test/elixir/version_test.exs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ defmodule VersionTest do
114114

115115
assert V.match?("0.9.3", "~> 0.9.3-dev")
116116
refute V.match?("0.10.0", "~> 0.9.3-dev")
117+
118+
refute V.match?("0.3.0-dev", "~> 0.2.0")
117119
end
118120

119121
test :and do

0 commit comments

Comments
 (0)