Merge pull request #4067 from vanstee/allow-false-value-in-env

Allow `false` value in env passed to `System.cmd/3`

Author: josevalim

lib/elixir/lib/system.ex

@@ -493,6 +493,8 @@ defmodule System do
 
   defp validate_env(enum) do
     Enum.map enum, fn
+      {k, false} ->
+        {String.to_char_list(k), false}
       {k, v} ->
         {String.to_char_list(k), String.to_char_list(v)}
       other ->

lib/elixir/test/elixir/system_test.exs

@@ -70,7 +70,7 @@ defmodule SystemTest do
 
   test "cmd/3 (with options)" do
     assert {["hello\n"], 0} = System.cmd "echo", ["hello"],
-                                into: [], cd: System.cwd!, env: %{"foo" => "bar"},
+                                into: [], cd: System.cwd!, env: %{"foo" => "bar", "baz" => false},
                                 arg0: "echo", stderr_to_stdout: true, parallelism: true
   end