Skip to content

Commit b558b90

Browse files
josevalimJosé Valim
authored andcommitted
Merge pull request #4409 from whatyouhide/version-build-metadata-fix
Allow dots in the metadata info in Version.parse/1 Signed-off-by: José Valim <[email protected]>
1 parent a97fcf9 commit b558b90

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

lib/elixir/lib/version.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ defmodule Version do
317317
(?:\.(\d+))? # minor
318318
(?:\.(\d+))? # patch
319319
(?:\-([\d\w\.\-]+))? # pre
320-
(?:\+([\d\w\-]+))? # build
320+
(?:\+([\d\w\.\-]+))? # build
321321
$/x
322322

323323
@spec parse_requirement(String.t) :: {:ok, Version.Requirement.t} | :error

lib/elixir/test/elixir/version_test.exs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ defmodule VersionTest do
6060
test "parse" do
6161
assert {:ok, %V{major: 1, minor: 2, patch: 3}} = V.parse("1.2.3")
6262
assert {:ok, %V{major: 1, minor: 4, patch: 5}} = V.parse("1.4.5+ignore")
63+
assert {:ok, %V{major: 0, minor: 0, patch: 1}} = V.parse("0.0.1+sha.0702245")
6364
assert {:ok, %V{major: 1, minor: 4, patch: 5, pre: ["6-g3318bd5"]}} = V.parse("1.4.5-6-g3318bd5")
6465
assert {:ok, %V{major: 1, minor: 4, patch: 5, pre: [6, 7, "eight"]}} = V.parse("1.4.5-6.7.eight")
6566
assert {:ok, %V{major: 1, minor: 4, patch: 5, pre: ["6-g3318bd5"]}} = V.parse("1.4.5-6-g3318bd5+ignore")

0 commit comments

Comments
 (0)