Skip to content

Commit b5e5797

Browse files
author
José Valim
committed
Remove undocumented Record.new(tuple) feature
1 parent 12f6a9a commit b5e5797

File tree

3 files changed

+3
-18
lines changed

3 files changed

+3
-18
lines changed

lib/elixir/lib/file.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ defmodule File do
246246
def stat(path, opts // []) do
247247
case F.read_file_info(path, opts) do
248248
{:ok, fileinfo} ->
249-
{:ok, File.Stat.new fileinfo}
249+
{:ok, set_elem(fileinfo, 0, File.Stat) }
250250
error ->
251251
error
252252
end

lib/elixir/lib/record.ex

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,6 @@ defmodule Record do
638638
@doc false
639639
def new([]), do: { __MODULE__, unquote_splicing(defaults) }
640640
def new(opts) when is_list(opts), do: { __MODULE__, unquote_splicing(selective) }
641-
def new(tuple) when is_tuple(tuple), do: :erlang.setelement(1, tuple, __MODULE__)
642641
end
643642
end
644643
@@ -780,7 +779,7 @@ defmodule Record do
780779
end
781780
782781
@spec new :: t
783-
@spec new(options | tuple) :: t
782+
@spec new(options) :: t
784783
@spec to_keywords(t) :: options
785784
@spec update(options, t) :: t
786785
@spec __record__(:name) :: atom

lib/elixir/test/elixir/record_test.exs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -78,21 +78,12 @@ defmodule RecordTest do
7878
require RecordTest.Macros
7979
RecordTest.Macros.gen
8080

81-
test :record_constructor_with_dict do
81+
test :basic_functions do
8282
record = RecordTest.FileInfo.new(type: :regular)
8383
assert record.type == :regular
8484
assert record.access == :undefined
8585
end
8686

87-
test :record_accessors do
88-
record = RecordTest.FileInfo.new(file_info)
89-
assert record.type == :regular
90-
assert record.access == :read_write
91-
92-
new_record = record.access :read
93-
assert new_record.access == :read
94-
end
95-
9687
test :dynamic_record_name do
9788
record = RecordTest.DynamicName.new
9889
assert record.a == 0
@@ -162,11 +153,6 @@ defmodule RecordTest do
162153
assert is_record(namespace, :xmlNamespace)
163154
end
164155

165-
defp file_info do
166-
{ :ok, file_info } = :file.read_file_info(__FILE__)
167-
file_info
168-
end
169-
170156
defp empty_tuple, do: {}
171157
defp a_tuple, do: { :foo, :bar, :baz }
172158
defp a_list, do: [ :foo, :bar, :baz ]

0 commit comments

Comments
 (0)