Skip to content

Commit d5a8821

Browse files
author
José Valim
committed
Merge pull request #1292 from devinus/github-git-protocol
Use the significantly faster Git protocol for github: dependencies
2 parents d849fc5 + aa7400a commit d5a8821

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/mix/lib/mix/scm/git.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ defmodule Mix.SCM.Git do
1313
def accepts_options(opts) do
1414
cond do
1515
gh = opts[:github] ->
16-
opts |> Keyword.delete(:github) |> Keyword.put(:git, "https://github.com/#{gh}.git")
16+
opts |> Keyword.delete(:github) |> Keyword.put(:git, "git://github.com/#{gh}.git")
1717
opts[:git] ->
1818
opts
1919
true ->

lib/mix/test/mix/tasks/deps_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ defmodule Mix.Tasks.DepsTest do
5757
in_fixture "deps_status", fn ->
5858
Mix.Tasks.Deps.run []
5959

60-
assert_received { :mix_shell, :info, ["* ok [git: \"https://github.com/elixir-lang/ok.git\"]"] }
60+
assert_received { :mix_shell, :info, ["* ok [git: \"git://github.com/elixir-lang/ok.git\"]"] }
6161
assert_received { :mix_shell, :info, [" locked at \"abcdef\""] }
6262
assert_received { :mix_shell, :info, [" lock mismatch: the dependency is out of date"] }
6363
assert_received { :mix_shell, :info, ["* invalidvsn [path: \"deps/invalidvsn\"]"] }
@@ -124,7 +124,7 @@ defmodule Mix.Tasks.DepsTest do
124124
Mix.Tasks.Deps.Check.run []
125125
end
126126

127-
assert_received { :mix_shell, :error, ["* ok [git: \"https://github.com/elixir-lang/ok.git\"]"] }
127+
assert_received { :mix_shell, :error, ["* ok [git: \"git://github.com/elixir-lang/ok.git\"]"] }
128128
assert_received { :mix_shell, :error, [" lock mismatch: the dependency is out of date"] }
129129
assert_received { :mix_shell, :error, ["* invalidvsn [path: \"deps/invalidvsn\"]"] }
130130
assert_received { :mix_shell, :error, [" the dependency does not match the specified version, got 0.1.0"] }

0 commit comments

Comments
 (0)