More reporting

Author: josevalim

lib/elixir/lib/inspect.ex

@@ -571,20 +571,26 @@ defimpl Inspect, for: Any do
       |> Enum.reject(&(&1 in except))
       |> Enum.filter(&(&1 in only))
 
-    optional? =
+    filtered_guard =
+      quote do
+        var!(field) in unquote(filtered_fields)
+      end
+
+    field_guard =
       if optional == [] do
-        false
+        filtered_guard
       else
         optional_map = for field <- optional, into: %{}, do: {field, Map.fetch!(struct, field)}
 
         quote do
-          case unquote(Macro.escape(optional_map)) do
-            %{^var!(field) => var!(default)} ->
-              var!(default) == Map.get(var!(struct), var!(field))
-
-            %{} ->
-              false
-          end
+          unquote(filtered_guard) and
+            not case unquote(Macro.escape(optional_map)) do
+              %{^var!(field) => var!(default)} ->
+                var!(default) == Map.get(var!(struct), var!(field))
+
+              %{} ->
+                false
+            end
         end
       end
 
@@ -593,7 +599,7 @@ defimpl Inspect, for: Any do
         def inspect(var!(struct), var!(opts)) do
           var!(infos) =
             for %{field: var!(field)} = var!(info) <- unquote(module).__info__(:struct),
-                var!(field) in unquote(filtered_fields) and not unquote(optional?),
+                unquote(field_guard),
                 do: var!(info)
 
           var!(name) = Macro.inspect_atom(:literal, unquote(module))

lib/elixir/src/elixir_expand.erl

@@ -732,7 +732,15 @@ expand_case(Meta, Expr, Opts, S, E) ->
     end,
 
   {EOpts, SO, EO} = elixir_clauses:'case'(Meta, ROpts, SE, EE),
-  {{'case', Meta, [EExpr, EOpts]}, SO, EO}.
+
+  case prune_case_clauses(EExpr, EOpts) of
+    {ok, Pruned} -> {Pruned, SO, EO};
+    error -> {{'case', Meta, [EExpr, EOpts]}, SO, EO}
+  end.
+
+prune_case_clauses(false, [{do, [{'->', _, [[false], Body]}, {'->', _, [[true], _]}]}]) -> {ok, Body};
+prune_case_clauses(true, [{do, [{'->', _, [[false], _]}, {'->', _, [[true], Body]}]}]) -> {ok, Body};
+prune_case_clauses(_, _) -> error.
 
 rewrite_case_clauses([{do, [
   {'->', FalseMeta, [

lib/elixir/test/elixir/module/types/expr_test.exs

@@ -1051,6 +1051,16 @@ defmodule Module.Types.ExprTest do
     end
   end
 
+  describe "conditionals" do
+    test "if does not report on literal booleans" do
+      assert typecheck!(
+               if true do
+                 :ok
+               end
+             ) == atom([:ok])
+    end
+  end
+
   describe "receive" do
     test "returns unions of all clauses" do
       assert typecheck!(