Skip to content

Commit d7bf2aa

Browse files
author
José Valim
committed
Lexer's valid_required? can now be private
1 parent 90d0e76 commit d7bf2aa

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

CHANGELOG.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
* [Kernel] Explicit functions inlined by the compiler, including operators. This means that `Kernel.+/2` will now expand to `:erlang.+/2` and so on
55
* [Mix] Do not fail if a Mix dependency relies on an outdated Elixir version
66
* [Process] Add `Process.send/2` and `Process.send_after/3`
7-
* [Version] Add `Version.compare/2`
8-
* [Version] Add `Version.valid_requirement?/1`
7+
* [Version] Add `Version.compare/2` and `Version.valid_requirement?/1`
98

109
* Bug fixes
1110
* [Atom] Inspect `:...` and `:foo@bar` without quoting

lib/elixir/lib/version.ex

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ defmodule Version do
360360
end
361361
end
362362

363-
@doc false
363+
@spec parse_pre(String.t) :: [String.t | integer]
364364
def parse_pre(pre) do
365365
String.split(pre, ".") |> Enum.map fn piece ->
366366
if Regex.match?(%r/^(0|[1-9][0-9]*)$/, piece) do
@@ -371,14 +371,8 @@ defmodule Version do
371371
end
372372
end
373373

374-
@spec valid_requirement?(list) :: boolean
375-
def valid_requirement?([]) do
376-
false
377-
end
378-
379-
def valid_requirement?([a | next]) do
380-
valid_requirement?(a, next)
381-
end
374+
defp valid_requirement?([]), do: false
375+
defp valid_requirement?([a | next]), do: valid_requirement?(a, next)
382376

383377
# it must finish with a version
384378
defp valid_requirement?(a, []) when is_binary(a) do

0 commit comments

Comments
 (0)