Skip to content

Commit e05448a

Browse files
author
José Valim
committed
Remove *_table terminolgy in favor of setup/cleanup
1 parent 55bc80b commit e05448a

File tree

3 files changed

+12
-17
lines changed

3 files changed

+12
-17
lines changed

lib/elixir/src/elixir_def.erl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
-module(elixir_def).
33
-export([table/1,
44
clauses_table/1,
5-
build_table/1,
6-
delete_table/1,
5+
setup/1,
6+
cleanup/1,
77
reset_last/1,
88
lookup_definition/2,
99
delete_definition/2,
@@ -21,15 +21,15 @@
2121
table(Module) -> ?atom_concat([f, Module]).
2222
clauses_table(Module) -> ?atom_concat([c, Module]).
2323

24-
build_table(Module) ->
24+
setup(Module) ->
2525
FunctionsTable = table(Module),
2626
ClausesTable = clauses_table(Module),
2727
ets:new(FunctionsTable, [set, named_table, public]),
2828
ets:new(ClausesTable, [bag, named_table, public]),
2929
reset_last(Module),
3030
{ FunctionsTable, ClausesTable }.
3131

32-
delete_table(Module) ->
32+
cleanup(Module) ->
3333
ets:delete(table(Module)),
3434
ets:delete(clauses_table(Module)).
3535

lib/elixir/src/elixir_import.erl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
-export([import/5, format_error/1,
66
ensure_no_import_conflict/4, ensure_no_local_conflict/4,
77
ensure_all_imports_used/3,
8-
build_table/1, delete_table/1, record/3]).
8+
setup/1, cleanup/1, record/3]).
99
-include("elixir.hrl").
1010

1111
%% This table keeps:
@@ -18,10 +18,10 @@
1818
%%
1919
table(Module) -> ?atom_concat([i, Module]).
2020

21-
build_table(Module) ->
21+
setup(Module) ->
2222
ets:new(table(Module), [bag, named_table, public]).
2323

24-
delete_table(Module) ->
24+
cleanup(Module) ->
2525
ets:delete(table(Module)).
2626

2727
record(_Tuple, _Receiver, nil) -> false;

lib/elixir/src/elixir_module.erl

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,10 @@ compile(Line, Module, Block, Vars, #elixir_scope{context_modules=FileModules} =
9191
{ module, Module, Binary, Result }
9292
after
9393
elixir_def_local:cleanup(Module),
94+
elixir_def:cleanup(Module),
95+
elixir_import:cleanup(Module),
9496
ets:delete(data_table(Module)),
95-
ets:delete(docs_table(Module)),
96-
elixir_def:delete_table(Module),
97-
elixir_import:delete_table(Module)
97+
ets:delete(docs_table(Module))
9898
end;
9999

100100
compile(Line, Other, _Block, _Vars, #elixir_scope{file=File}) ->
@@ -137,13 +137,8 @@ build(Line, File, Module) ->
137137

138138
%% Setup other modules
139139
elixir_def_local:setup(Module),
140-
141-
%% We keep a separated table for function definitions
142-
%% and another one for imports. We keep them in different
143-
%% tables for organization and speed purpose (since the
144-
%% imports table is frequently written to).
145-
elixir_def:build_table(Module),
146-
elixir_import:build_table(Module).
140+
elixir_def:setup(Module),
141+
elixir_import:setup(Module).
147142

148143
%% Receives the module representation and evaluates it.
149144

0 commit comments

Comments
 (0)