Mix should not depend directly on Logger

Author: ericmj

lib/mix/lib/mix/tasks/app.start.ex

@@ -28,7 +28,9 @@ defmodule Mix.Tasks.App.Start do
     # Stop the Logger after we have used it for compilation.
     # It is up to the application to decide if it should be
     # restarted or not.
-    Logger.App.stop()
+    # Mix should not depend directly on Logger so check that
+    # it's loaded.
+    if Code.ensure_loaded?(Logger), do: Logger.App.stop()
 
     unless "--no-start" in args do
       start(Mix.Project.config[:app])

lib/mix/test/mix/task_test.exs

@@ -23,14 +23,16 @@ defmodule Mix.TaskTest do
   end
 
   test "try to compile if task is missing" do
-    Mix.Project.push(SampleProject, "sample")
+    in_fixture "no_mixfile", fn ->
+      Mix.Project.push(SampleProject, "sample")
 
-    assert_raise Mix.NoTaskError, fn ->
-      Mix.Task.run("unknown")
-    end
+      assert_raise Mix.NoTaskError, fn ->
+        Mix.Task.run("unknown")
+      end
 
-    # Check if compile task have run
-    refute Mix.TasksServer.run({:task, "compile", Mix.Project.get})
+      # Check if compile task have run
+      refute Mix.TasksServer.run({:task, "compile", Mix.Project.get})
+    end
   end
 
   test "clear/0" do