Ensure Enum.to_list and Dict.to_list return the same results for dicts

Author: José Valim

CHANGELOG.md

@@ -3,6 +3,7 @@
 * enhancements
 
 * bug fix
+  * [Dict] `Enum.to_list` and `Dict.to_list` now return the same results for dicts
   * [Mix] Fix a bug where `mix deps.get` was not retrieving nested dependencies
 
 * deprecations

lib/elixir/lib/hash_dict.ex

@@ -246,7 +246,7 @@ defmodule HashDict do
   end
 
   def to_list(dict) do
-    dict_fold(dict, [], [&1|&2])
+    dict_fold(dict, [], [&1|&2]) |> :lists.reverse
   end
 
   @doc """

lib/elixir/test/elixir/hash_dict_test.exs

@@ -85,17 +85,23 @@ defmodule HashDictTest do
   end
 
   test :to_list do
-    list = filled_dict(8) |> HashDict.to_list
+    dict = filled_dict(8)
+    list = dict |> HashDict.to_list
     assert length(list) == 8
     assert { 1, 1 } in list
+    assert list == Enum.to_list(dict)
 
-    list = filled_dict(20) |> HashDict.to_list
+    dict = filled_dict(20)
+    list = dict |> HashDict.to_list
     assert length(list) == 20
     assert { 1, 1 } in list
+    assert list == Enum.to_list(dict)
 
-    list = filled_dict(120) |> HashDict.to_list
+    dict = filled_dict(120)
+    list = dict |> HashDict.to_list
     assert length(list) == 120
     assert { 1, 1 } in list
+    assert list == Enum.to_list(dict)
   end
 
   test :keys do