Apply changes from CR

Author: am-kantox

lib/mix/lib/mix/task.ex

@@ -613,11 +613,8 @@ defmodule Mix.Task do
   child projects.
   """
   @spec reenable(task_name) :: :ok
-  def reenable(task) when is_atom(task) do
-    task |> to_string() |> reenable()
-  end
-
-  def reenable(task) when is_binary(task) do
+  def reenable(task) when is_binary(task) or is_atom(task) do
+    task = to_string(task)
     proj = Mix.Project.get()
     recursive = (module = get(task)) && recursive(module)
 

lib/mix/lib/mix/tasks/compile.ex

@@ -82,6 +82,27 @@ defmodule Mix.Tasks.Compile do
   @deprecated "Use Mix.Task.Compiler.compilers/1 instead"
   defdelegate compilers(config \\ Mix.Project.config()), to: Mix.Task.Compiler
 
+  @doc """
+  Reenables given compilers so they can be executed again down the stack.
+
+  If an umbrella project reenables compilers, they are re-enabled for all
+  child projects.
+
+  Default is `[]`, for none compilers to be reenabled.
+  This task always re-enables `"compiler.all"`.
+  """
+  @spec reenable([{:compilers, compilers}]) :: :ok when compilers: :all | [Mix.Task.task_name()]
+  def reenable(opts \\ []) do
+    compilers =
+      case Keyword.get(opts, :compilers, :all) do
+        :all -> compilers()
+        list when is_list(list) -> list
+      end
+
+    Enum.each(["compile", "compile.all"], &Mix.Task.reenable(&1))
+    Enum.each(compilers, &Mix.Task.reenable("compile.#{&1}"))
+  end
+
   @impl true
   def run(["--list"]) do
     # Loadpaths without checks because compilers may be defined in deps.

lib/mix/test/mix/tasks/compile_test.exs

@@ -117,7 +117,9 @@ defmodule Mix.Tasks.CompileTest do
       assert Mix.Tasks.Compile.run(["--verbose"]) == {:ok, []}
       Mix.shell().flush()
 
-      File.write!("lib/z.ex", """
+      File.mkdir_p!("lib/foo")
+
+      File.write!("lib/foo/z.ex", """
       defmodule Z do
         def ok, do: :ok
       end
@@ -127,15 +129,15 @@ defmodule Mix.Tasks.CompileTest do
       assert {:noop, []} = Mix.Task.run("compile")
       refute File.regular?("_build/dev/lib/sample/ebin/Elixir.Z.beam")
 
-      assert :ok = Mix.Task.Compiler.reenable()
+      assert :ok = Mix.Tasks.Compile.reenable(compilers: [])
       assert {:noop, []} = Mix.Task.run("compile")
       refute File.regular?("_build/dev/lib/sample/ebin/Elixir.Z.beam")
 
-      assert :ok = Mix.Task.Compiler.reenable(compilers: ["erlang"])
+      assert :ok = Mix.Tasks.Compile.reenable(compilers: ["erlang"])
       assert {:noop, []} = Mix.Task.run("compile")
       refute File.regular?("_build/dev/lib/sample/ebin/Elixir.Z.beam")
 
-      assert :ok = Mix.Task.Compiler.reenable(compilers: ["elixir", "erlang"])
+      assert :ok = Mix.Tasks.Compile.reenable()
       assert {:ok, []} = Mix.Task.run("compile")
       assert File.regular?("_build/dev/lib/sample/ebin/Elixir.Z.beam")
     end)