Handle the enotdir case in ls helper

Author: sabiwara

lib/iex/lib/iex/helpers.ex

@@ -1081,7 +1081,11 @@ defmodule IEx.Helpers do
         IO.puts(IEx.color(:eval_error, "No such file or directory #{path}"))
 
       {:error, :enotdir} ->
-        IO.puts(IEx.color(:eval_info, Path.absname(path)))
+        if File.exists?(path) do
+          IO.puts(IEx.color(:eval_info, Path.absname(path)))
+        else
+          IO.puts(IEx.color(:eval_error, "Not a directory #{path}"))
+        end
 
       {:error, reason} ->
         IO.puts(IEx.color(:eval_error, :file.format_error(reason)))

lib/iex/test/iex/helpers_test.exs

@@ -1213,6 +1213,15 @@ defmodule IEx.HelpersTest do
                  "No such file or directory unknown_dir\n"
       end)
     end
+
+    test "prints an error if part of the path is not a dir (enotdir)" do
+      File.cd!(iex_path(), fn ->
+        path = Path.join("mix.exs", "foo")
+
+        assert capture_io(fn -> ls(path) end) ==
+                 "Not a directory #{path}\n"
+      end)
+    end
   end
 
   describe "exports" do