Feat: Add examples to exception.ex for clearer error handling #14227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bennydreamtech23
commented
Jan 25, 2025
bennydreamtech23
commented
- Adds example to the module with only an explanation but no example, to see how the error is caused.
- Some module in exception do not have description for example: UnicodeConversionError module
- These changes was added to enrich the documentation to assist developers understand how the exception are raised.
josevalim
reviewed
Jan 27, 2025
josevalim
reviewed
Jan 27, 2025
|
Thank you, beautiful work. I have pushed some improvements and I will merge it once CI passes. |
krns
reviewed
Jan 27, 2025
Co-authored-by: Simon Hansen <[email protected]>
|
💚 💙 💜 💛 ❤️ |
|
Thank you for the support and I am so happy 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.