Optimize subtype? by aborting early #14561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the same way we introduced non_disjoint_intersection to optimize compatibility, we introduce empty_difference to optimize subtyping.
|
💚 💙 💜 💛 ❤️ |
sabiwara
reviewed
Jun 7, 2025
|
|
||
| defp iterator_difference_static(:none, map), do: map | ||
|
|
||
| defp empty_difference_static?(left, :term), do: not Map.has_key?(left, :optional) |
There was a problem hiding this comment.
@josevalim sorry asking for my understanding, couldn't figure this one out.
What would be an example case that justifies checking for optional?
Currently the following seems to pass all the tests, so it's probably not covered:
- defp empty_difference_static?(left, :term), do: not Map.has_key?(left, :optional)
+ defp empty_difference_static?(left, :term), do: trueThere was a problem hiding this comment.
I don't think there is a practical example, but i am keeping semantic equivalence with the empty? function. empty? check if all fields empty and, if optional is set, it is not considered empty. So I am doing the same here. I have asked @gldubc if empty?(optional(none()) is true or false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same way we introduced
non_disjoint_intersectionto optimize compatibility, we introduce
empty_differenceto optimize subtyping.