Relax assertions when both PER CALL values are equal (Erlang/OTP 28)

[Eiji7]

Fixes: #14564

This fix implements Erlang/OTP version check. The alternative solution could be:

# extract results
[_warmup, _profile_results, _columns, _total, first, second, _profile_done, ""] =
  String.split(result, ~r/\n+/)

# split columns
list = Enum.map([first, second], &String.split(&1, ~r/\s+/))

sort_func = fn result_colls ->
  result_colls
  |> List.last()
  |> String.to_float()
end

list == Enum.sort_by(list, sort_func)

The alternative solution additionally does not relies on 3.\d{2} value pattern of PER CALL column.

[josevalim]

I like your alternative solution, relying less on regexes, but we should also check on the calls. Perhaps we build {per_call, mfa} tuples and assert on the names after sorting?

[Eiji7]

@josevalim I have send an alternative version. Unfortunately we cannot guarantee the order of mfa strings since they may not be sorted if both PER CALL column values are same (in my case 3.00). No problem to change it with a different expression than @expr that works on every Erlang/OTP release.

Here are my results for this task:

$ mix profile.tprof --type memory --sort per_call -e "Enum.each(1..5, &String.Chars.Integer.to_string/1)"
Warmup...


Profile results of #PID<0.155.0>
#                           CALLS      % WORDS PER CALL
Total                           6 100.00    18     3.00
Enum.each/2                     1  16.67     3     3.00
:erlang.integer_to_binary/1     5  83.33    15     3.00

Profile done over 2 matching functions

[Eiji7]

Oh, wait - I have just realised something something … This is the only test that uses --sort argument with per_call value. We can just sort by calls and then verify the sorted result. For some reason my mind was fixed on not changing this task call at all. 😅

[Eiji7]

@josevalim I have reverted back to old regex solution, because it's shorter, but I kept the change in --sort argument value, so now we are sure that they are always properly sorted regardless of JIT, architecture or Erlang/OTP version. This resulted in swapping the order of expected lines, so now Enum.each/2 is expected first. I have also added patterns to verify the calls column value (1 and 5 surrounded by whitespaces and right after mfa).