Refactor formatter module name handling and improve markdown template spec attribute formatting

Author: yordis

lib/ex_doc.ex

@@ -35,11 +35,16 @@ defmodule ExDoc do
   end
 
   defp find_formatter(name) do
-    [ExDoc.Formatter, String.upcase(name)]
+    [ExDoc.Formatter, format_module_name(name)]
     |> Module.concat()
     |> check_formatter_module(name)
   end
 
+  defp format_module_name("html"), do: "HTML"
+  defp format_module_name("epub"), do: "EPUB"
+  defp format_module_name("markdown"), do: "Markdown"
+  defp format_module_name(name), do: String.upcase(name)
+
   defp check_formatter_module(modname, argname) do
     if Code.ensure_loaded?(modname) do
       modname

lib/ex_doc/formatter/markdown/templates.ex

@@ -26,7 +26,7 @@ defmodule ExDoc.Formatter.Markdown.Templates do
   def module_type(%{type: type} = _node), do: "(#{type})"
 
   @doc """
-  Formats the attribute type used to define the spec of the given `node`. 
+  Formats the attribute type used to define the spec of the given `node`.
   """
   def format_spec_attribute(module, node) do
     module.language.format_spec_attribute(node)
@@ -149,7 +149,7 @@ defmodule ExDoc.Formatter.Markdown.Templates do
   @spec synopsis(nil) :: nil
   def synopsis(doc) when is_binary(doc) do
     case :binary.split(doc, "\n\n") do
-      [left, _] -> String.trim_trailing(left) |> String.trim_trailing(left, ":") <> "\n\n"
+      [left, _] -> (String.trim_trailing(left) |> String.trim_trailing(":")) <> "\n\n"
       [all] -> all
     end
   end