refactor: use quote + base64 to pass eval string

This is the same method Livebook uses for the very same reasons

Author: doorgan

apps/expert/lib/expert/engine_node.ex

@@ -40,20 +40,8 @@ defmodule Expert.EngineNode do
             state.cookie,
             "--no-halt",
             "-e",
-            # We manually start distribution here instead of using --sname/--name
-            # because those options are not really compatible with `-epmd_module`.
-            # Apparently, passing the --name/-sname options causes the Erlang VM
-            # to start distribution right away before the modules in the code path
-            # are loaded, and it will crash because Forge.EPMD doesn't exist yet.
-            # If we start distribution manually after all the code is loaded,
-            # everything works fine.
-            # We also need to pass the command as a single line with ;\, otherwise
-            # this will only run the first line on Windows.
-            """
-            {:ok, _} = Node.start(:"#{Project.node_name(state.project)}", :longnames);\
-            #{Forge.NodePortMapper}.register();\
-            IO.puts(\"ok\");\
-            """
+            "System.argv() |> hd() |> Base.decode64!() |> Code.eval_string()",
+            project_node_eval_string(state.project)
           ]
 
       env =
@@ -74,6 +62,26 @@ defmodule Expert.EngineNode do
       end
     end
 
+    defp project_node_eval_string(project) do
+      # We pass the child node code as --eval argument. Windows handles
+      # escaped quotes and newlines differently from Unix, so to avoid
+      # those kind of issues, we encode the string in base 64 and pass
+      # as positional argument. Then, we use a simple --eval that decodes
+      # and evaluates the string.
+      project_node = Project.node_name(project)
+
+      quote do
+        node = unquote(project_node)
+
+        # We start distribution here, rather than on node boot, so that
+        # -pa takes effect and Forge.EPMD is available
+        {:ok, _} = Node.start(node, :longnames)
+        Forge.NodePortMapper.register()
+      end
+      |> Macro.to_string()
+      |> Base.encode64()
+    end
+
     def stop(%__MODULE__{} = state, from, stop_timeout) do
       project_rpc(state, System, :stop)
       %{state | stopped_by: from, stop_timeout: stop_timeout, status: :stopping}