fix: start projects after server is initialized (#294)

#18 introduced an issue where progress is trying to be reported before
the server is initialized, which causes the client to report back an
error and stops the server from starting up properly in VSCode.

This fix ensures we start the projects only after the server is fully
initialized, and so the progress from those projects is reproted at the
right time.

Author: doorgan

apps/expert/lib/expert.ex

@@ -70,15 +70,7 @@ defmodule Expert do
 
       ActiveProjects.set_projects(projects)
 
-      for project <- projects do
-        Task.Supervisor.start_child(:expert_task_queue, fn ->
-          log_info(lsp, project, "Starting project")
-
-          start_result = Expert.Project.Supervisor.ensure_node_started(project)
-
-          send(Expert, {:engine_initialized, project, start_result})
-        end)
-      end
+      # Projects will be started when we receive the initialized notification
 
       {:reply, response, assign(lsp, state: state)}
     else
@@ -197,6 +189,16 @@ defmodule Expert do
       Logger.error("Failed to register capability")
     end
 
+    for project <- ActiveProjects.projects() do
+      Task.Supervisor.start_child(:expert_task_queue, fn ->
+        log_info(lsp, project, "Starting project")
+
+        start_result = Expert.Project.Supervisor.ensure_node_started(project)
+
+        send(Expert, {:engine_initialized, project, start_result})
+      end)
+    end
+
     {:noreply, lsp}
   end
 

apps/expert/test/expert/expert_test.exs

@@ -110,6 +110,14 @@ defmodule ExpertTest do
     }
   end
 
+  def initialized_notification do
+    %{
+      method: "initialized",
+      jsonrpc: "2.0",
+      params: %{}
+    }
+  end
+
   def assert_project_alive?(project) do
     expected_uri = project.root_uri
     assert_receive {:project_alive, ^expected_uri}
@@ -136,6 +144,10 @@ defmodule ExpertTest do
         "capabilities" => %{"workspace" => %{"workspaceFolders" => %{"supported" => true}}}
       })
 
+      assert :ok = notify(client, initialized_notification())
+
+      assert_request(client, "client/registerCapability", fn _params -> nil end)
+
       expected_message = "Started project node for #{Project.name(main_project)}"
 
       assert_notification(
@@ -165,6 +177,10 @@ defmodule ExpertTest do
 
       assert_result(1, _)
 
+      assert :ok = notify(client, initialized_notification())
+
+      assert_request(client, "client/registerCapability", fn _params -> nil end)
+
       expected_message = "Started project node for #{Project.name(main_project)}"
 
       assert_notification(
@@ -218,6 +234,11 @@ defmodule ExpertTest do
                )
 
       assert_result(1, _)
+
+      assert :ok = notify(client, initialized_notification())
+
+      assert_request(client, "client/registerCapability", fn _params -> nil end)
+
       expected_message = "Started project node for #{Project.name(main_project)}"
 
       assert_notification(
@@ -291,6 +312,10 @@ defmodule ExpertTest do
 
       assert_result(1, _)
 
+      assert :ok = notify(client, initialized_notification())
+
+      assert_request(client, "client/registerCapability", fn _params -> nil end)
+
       expected_message = "Started project node for #{Project.name(main_project)}"
 
       assert_notification(
@@ -484,6 +509,10 @@ defmodule ExpertTest do
 
       assert_result(1, _)
 
+      assert :ok = notify(client, initialized_notification())
+
+      assert_request(client, "client/registerCapability", fn _params -> nil end)
+
       expected_message = "Started project node for #{Project.name(nested_root_project)}"
 
       assert_notification(