Merge branch 'main' into fix-91

Author: heywhy

README.md

@@ -50,7 +50,7 @@ Thank you to our corporate sponsors! If you'd like to start sponsoring the proje
 
 ### Corporate
 
-For companies wanting to directly sponsor full time work on Expert, please reach out to Dan Janowski: EEF Chair of Sponsorship WG at danj@erlef.org.
+For companies wanting to directly sponsor full time work on Expert, please reach out to Dan Janowski: EEF Chair of Sponsorship WG at sponsor+expert (at)  erlef (dot) org.
 
 ### Individual
 

apps/engine/lib/engine/analyzer.ex

@@ -205,7 +205,7 @@ defmodule Engine.Analyzer do
     # Trailing aliases happen when you use the curly syntax to define multiple aliases
     # in one go, like Foo.{First, Second.Third, Fourth}
     # Our alias mapping will have Third mapped to Foo.Second.Third, so we need to look
-    # for Third, wheras the leading alias will look for Second in the mappings.
+    # for Third, whereas the leading alias will look for Second in the mappings.
     with {:ok, resolved} <- Map.fetch(aliases_mapping, List.last(segments)) do
       {:ok, List.wrap(resolved)}
     end

apps/engine/lib/engine/api/proxy.ex

@@ -23,8 +23,8 @@ defmodule Engine.Api.Proxy do
 
   Internally, there are three states: proxying, draining and buffering.
   The proxy starts in proxying mode. Then, when start_buffering is called, it changes to draining mode. This
-  mode checks if there are any in-flight calls. If there aren't any, it changes immediately to buffring mode.
-  If there are in-flight reqeusts, it waits for them to finish, and then switches to buffer mode. Once in buffer
+  mode checks if there are any in-flight calls. If there aren't any, it changes immediately to buffering mode.
+  If there are in-flight requests, it waits for them to finish, and then switches to buffer mode. Once in buffer
   mode, requests are buffered until the process that called `start_buffering` exits. When that happens, then
   the requests are de-duplicated and run, and then the proxy returns to proxying mode.
 

apps/engine/lib/engine/bootstrap.ex

@@ -75,7 +75,7 @@ defmodule Engine.Bootstrap do
 
     # Note about the following code:
     # I tried a bunch of stuff to get it to work, like checking if the
-    # app is an umbrella (umbrealla? returns false when started in a subapp)
+    # app is an umbrella (umbrella? returns false when started in a subapp)
     # to no avail. This was the only thing that consistently worked
     {:ok, configured_root} =
       Engine.Mix.in_project(project, fn _ ->

apps/engine/lib/engine/build/project.ex

@@ -104,7 +104,7 @@ defmodule Engine.Build.Project do
 
   defp connected_to_internet? do
     # While there's no perfect way to check if a computer is connected to the internet,
-    # it seems reasonable to gate pulling dependenices on a resolution check for hex.pm.
+    # it seems reasonable to gate pulling dependencies on a resolution check for hex.pm.
     # Yes, it's entirely possible that the DNS server is local, and that the entry is in cache,
     # but that's an edge case, and the build will just time out anyways.
     case :inet_res.getbyname(~c"hex.pm", :a, 250) do

apps/engine/lib/engine/search/fuzzy/scorer.ex

@@ -230,7 +230,7 @@ defmodule Engine.Search.Fuzzy.Scorer do
     {streak_length, @consecutive_character_bonus * streak_length}
   end
 
-  @mismatched_chracter_penalty 5
+  @mismatched_character_penalty 5
 
   def mismatched_penalty(matched_positions) do
     {penalty, _} =
@@ -244,7 +244,7 @@ defmodule Engine.Search.Fuzzy.Scorer do
         matched_position, {penalty, last_match} ->
           distance = matched_position - last_match
 
-          {penalty + distance * @mismatched_chracter_penalty, matched_position}
+          {penalty + distance * @mismatched_character_penalty, matched_position}
       end)
 
     penalty

apps/engine/lib/engine/search/indexer.ex

@@ -101,7 +101,7 @@ defmodule Engine.Search.Indexer do
     total_bytes = paths_to_sizes |> Enum.map(&elem(&1, 1)) |> Enum.sum()
 
     if total_bytes > 0 do
-      {on_update_progess, on_complete} =
+      {on_update_progress, on_complete} =
         Progress.begin_percent("Indexing source code", total_bytes)
 
       initial_state = {0, []}
@@ -131,7 +131,7 @@ defmodule Engine.Search.Indexer do
         fn chunk ->
           block_bytes = chunk |> Enum.map(&Map.get(path_to_size_map, &1)) |> Enum.sum()
           result = Enum.map(chunk, processor)
-          on_update_progess.(block_bytes, "Indexing")
+          on_update_progress.(block_bytes, "Indexing")
           result
         end,
         timeout: timeout

apps/engine/lib/engine/search/indexer/extractors/module.ex

@@ -278,14 +278,14 @@ defmodule Engine.Search.Indexer.Extractors.Module do
 
   defp module(_, _), do: :error
 
-  @protocol_module_attribue_names [:protocol, :for]
+  @protocol_module_attribute_names [:protocol, :for]
 
   @starts_with_capital ~r/[A-Z]+/
   defp module_part?(part) when is_atom(part) do
     Regex.match?(@starts_with_capital, Atom.to_string(part))
   end
 
-  defp module_part?({:@, _, [{type, _, _} | _]}) when type in @protocol_module_attribue_names,
+  defp module_part?({:@, _, [{type, _, _} | _]}) when type in @protocol_module_attribute_names,
     do: true
 
   defp module_part?({:__MODULE__, _, context}) when is_atom(context), do: true
@@ -306,7 +306,7 @@ defmodule Engine.Search.Indexer.Extractors.Module do
 
   # handles @protocol and @for in defimpl blocks
   defp to_range(%Reducer{} = reducer, [{:@, _, [{type, _, _} | _]} = attribute | segments], _)
-       when type in @protocol_module_attribue_names do
+       when type in @protocol_module_attribute_names do
     range = Sourceror.get_range(attribute)
 
     document = reducer.analysis.document

apps/engine/lib/engine/search/store/backends/ets/wal.ex

@@ -84,8 +84,8 @@ defmodule Engine.Search.Store.Backends.Ets.Wal do
     exists?(wal.project, wal.schema_version)
   end
 
-  def exists?(%Project{} = project, schema_vesion) do
-    case File.ls(wal_directory(project, schema_vesion)) do
+  def exists?(%Project{} = project, schema_version) do
+    case File.ls(wal_directory(project, schema_version)) do
       {:ok, [_]} -> true
       {:ok, [_ | _]} -> true
       _ -> false

apps/engine/test/engine/analyzer/imports_test.exs

@@ -98,7 +98,7 @@ defmodule Engine.Ast.Analysis.ImportsTest do
       assert_imported(imports, ImportedModule)
     end
 
-    test "single underscore functions aren't imported by defualt" do
+    test "single underscore functions aren't imported by default" do
       imports =
         ~q[
           import Parent.Child.ImportedModule