Unexpected return values for Expert.Configuration.client_supports?/1 #113
Description
While debugging something I stumbled upon this:
iex> Expert.Configuration.client_supports?(:tags)
%{value_set: [1]}
iex> Expert.Configuration.client_supports?(:signature_help)
%GenLSP.Structures.SignatureHelpClientCapabilities{
context_support: nil,
signature_information: %{
documentation_format: ["markdown", "plaintext"],
parameter_information: %{label_offset_support: true},
active_parameter_support: true
},
dynamic_registration: false
}The function spec claims the function only returns a boolean:
expert/apps/expert/lib/expert/configuration.ex
Lines 56 to 57 in e510182
I wanted to prepare a PR, but then I was wondering whether we should simply check for value !== false to see if that feature is supported or if there is more logic needed to figure out whether those features are supported or not 🤷