don't send telemetry on expected errors

Author: lukaszsamson

apps/language_server/lib/language_server/dialyzer/analyzer.ex

@@ -1,6 +1,7 @@
 defmodule ElixirLS.LanguageServer.Dialyzer.Analyzer do
   require Record
   require Logger
+  alias ElixirLS.LanguageServer.JsonRpc
 
   # warn_race_condition is unsupported because it greatly increases analysis time
   # OTP 25 dropped support for warn_race_condition

apps/language_server/lib/language_server/providers/document_symbols.ex

@@ -32,7 +32,7 @@ defmodule ElixirLS.LanguageServer.Providers.DocumentSymbols do
         {:ok, build_symbols(symbols, uri, text, hierarchical)}
 
       {:error, :compilation_error} ->
-        {:error, :server_error, "[DocumentSymbols] Compilation error while parsing source file"}
+        {:error, :server_error, "Cannot parse source file", false}
     end
   end
 

apps/language_server/lib/language_server/providers/execute_command.ex

@@ -23,7 +23,7 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand do
       handler.execute(args, state)
     else
       _ ->
-        {:error, :invalid_request, nil}
+        {:error, :invalid_request, nil, true}
     end
   end
 

apps/language_server/lib/language_server/providers/execute_command/apply_spec.ex

@@ -90,7 +90,7 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.ApplySpec do
 
       other ->
         {:error, :server_error,
-         "cannot insert spec, workspace/applyEdit returned #{inspect(other)}"}
+         "cannot insert spec, workspace/applyEdit returned #{inspect(other)}", true}
     end
   end
 end

apps/language_server/lib/language_server/providers/execute_command/get_ex_unit_tests_in_file.ex

@@ -7,8 +7,11 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.GetExUnitTestsInFile
     path = SourceFile.Path.from_uri(uri)
 
     case ExUnitTestTracer.get_tests(path) do
-      {:ok, tests} -> {:ok, tests}
-      {:error, reason} -> {:error, :server_error, inspect(reason)}
+      {:ok, tests} ->
+        {:ok, tests}
+
+      {:error, reason} ->
+        {:error, :server_error, "Cannot get tests in file: #{inspect(reason)}", true}
     end
   end
 end

apps/language_server/lib/language_server/providers/execute_command/manipulate_pipes.ex

@@ -52,17 +52,17 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.ManipulatePipes do
       {:ok, nil}
     else
       {:error, :pipe_not_found} ->
-        {:error, :parse_error, "Pipe operator not found at cursor"}
+        {:error, :parse_error, "Pipe operator not found at cursor", false}
 
       {:error, :function_call_not_found} ->
-        {:error, :parse_error, "Function call not found at cursor"}
+        {:error, :parse_error, "Function call not found at cursor", false}
 
       {:error, :invalid_code} ->
-        {:error, :parse_error, "Malformed code"}
+        {:error, :parse_error, "Malformed code", false}
 
       error ->
         {:error, :server_error,
-         "Cannot execute pipe conversion, workspace/applyEdit returned #{inspect(error)}"}
+         "Cannot execute pipe conversion, workspace/applyEdit returned #{inspect(error)}", true}
     end
   end
 

apps/language_server/lib/language_server/providers/execute_command/mix_clean.ex

@@ -5,7 +5,7 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.MixClean do
   def execute([clean_deps?], _state) do
     case ElixirLS.LanguageServer.Build.clean(clean_deps?) do
       :ok -> {:ok, %{}}
-      {:error, reason} -> {:error, :server_error, inspect(reason)}
+      {:error, reason} -> {:error, :server_error, "Mix clean failed: #{inspect(reason)}", true}
     end
   end
 end

apps/language_server/lib/language_server/providers/folding_range.ex

@@ -84,15 +84,11 @@ defmodule ElixirLS.LanguageServer.Providers.FoldingRange do
       ]}
 
   """
-  @spec provide(%{text: String.t()}) :: {:ok, [t()]} | {:error, String.t()}
+  @spec provide(%{text: String.t()}) :: {:ok, [t()]}
   def provide(%{text: text}) do
     do_provide(text)
   end
 
-  def provide(not_a_source_file) do
-    {:error, "Expected a source file, found: #{inspect(not_a_source_file)}"}
-  end
-
   defp do_provide(text) do
     input = convert_text_to_input(text)
 

apps/language_server/lib/language_server/providers/folding_range/token.ex

@@ -6,6 +6,7 @@ defmodule ElixirLS.LanguageServer.Providers.FoldingRange.Token do
   """
 
   alias ElixirSense.Core.Normalized.Tokenizer
+  alias ElixirLS.LanguageServer.JsonRpc
   require Logger
 
   @type t :: {atom(), {non_neg_integer(), non_neg_integer(), any()}, any()}

apps/language_server/lib/language_server/providers/formatting.ex

@@ -15,14 +15,14 @@ defmodule ElixirLS.LanguageServer.Providers.Formatting do
           end
 
         :error ->
-          {:error, :internal_error, "Unable to fetch formatter options"}
+          {:error, :internal_error, "Unable to fetch formatter options", true}
       end
     else
       msg =
         "Cannot format file from current directory " <>
           "(Currently in #{Path.relative_to(File.cwd!(), project_dir)})"
 
-      {:error, :internal_error, msg}
+      {:error, :internal_error, msg, true}
     end
   end
 
@@ -42,7 +42,7 @@ defmodule ElixirLS.LanguageServer.Providers.Formatting do
     {:ok, response}
   rescue
     _e in [TokenMissingError, SyntaxError] ->
-      {:error, :internal_error, "Unable to format due to syntax error"}
+      {:error, :internal_error, "Unable to format due to syntax error", false}
   end
 
   defp get_formatted(text, formatter, _) when is_function(formatter) do