workaround a crash on windows in OTP 27

Author: lukaszsamson

apps/language_server/lib/language_server/providers/workspace_symbols.ex

@@ -67,8 +67,8 @@ defmodule ElixirLS.LanguageServer.Providers.WorkspaceSymbols do
     GenServer.start_link(__MODULE__, :ok, opts |> Keyword.put_new(:name, __MODULE__))
   end
 
-  def notify_settings_stored() do
-    GenServer.cast(__MODULE__, :notify_settings_stored)
+  def notify_settings_stored(project_dir) do
+    GenServer.cast(__MODULE__, {:notify_settings_stored, project_dir})
   end
 
   def notify_build_complete(server \\ __MODULE__) do
@@ -150,9 +150,7 @@ defmodule ElixirLS.LanguageServer.Providers.WorkspaceSymbols do
   end
 
   @impl GenServer
-  def handle_cast(:notify_settings_stored, state) do
-    project_dir = :persistent_term.get(:language_server_project_dir)
-
+  def handle_cast({:notify_settings_stored, project_dir}, state) do
     # as of LSP 3.17 only one tag is defined and clients are required to silently ignore unknown tags
     # so there's no need to pass the list
     tag_support =

apps/language_server/lib/language_server/server.ex

@@ -1865,9 +1865,8 @@ defmodule ElixirLS.LanguageServer.Server do
     state = create_gitignore(state)
 
     if state.mix_project? do
-      :persistent_term.put(:language_server_project_dir, state.project_dir)
-      WorkspaceSymbols.notify_settings_stored()
-      Tracer.notify_settings_stored()
+      WorkspaceSymbols.notify_settings_stored(state.project_dir)
+      Tracer.notify_settings_stored(state.project_dir)
     end
 
     JsonRpc.telemetry(

apps/language_server/lib/language_server/tracer.ex

@@ -20,8 +20,8 @@ defmodule ElixirLS.LanguageServer.Tracer do
     GenServer.start_link(__MODULE__, args, name: __MODULE__)
   end
 
-  def notify_settings_stored() do
-    GenServer.cast(__MODULE__, :notify_settings_stored)
+  def notify_settings_stored(project_dir) do
+    GenServer.cast(__MODULE__, {:notify_settings_stored, project_dir})
   end
 
   defp get_project_dir() do
@@ -53,8 +53,7 @@ defmodule ElixirLS.LanguageServer.Tracer do
       ])
     end
 
-    project_dir = :persistent_term.get(:language_server_project_dir, nil)
-    state = %{project_dir: project_dir}
+    state = %{project_dir: nil}
 
     {:ok, state}
   end
@@ -65,9 +64,7 @@ defmodule ElixirLS.LanguageServer.Tracer do
   end
 
   @impl true
-  def handle_cast(:notify_settings_stored, state) do
-    project_dir = :persistent_term.get(:language_server_project_dir)
-
+  def handle_cast({:notify_settings_stored, project_dir}, state) do
     for table <- @tables do
       table_name = table_name(table)
       :ets.delete_all_objects(table_name)

apps/language_server/test/providers/references_test.exs

@@ -13,8 +13,8 @@ defmodule ElixirLS.LanguageServer.Providers.ReferencesTest do
     File.rm_rf!(FixtureHelpers.get_path(".elixir_ls/calls.dets"))
     {:ok, pid} = Tracer.start_link([])
     project_path = FixtureHelpers.get_path("")
-    :persistent_term.put(:language_server_project_dir, project_path)
-    Tracer.notify_settings_stored()
+
+    Tracer.notify_settings_stored(project_path)
 
     compiler_options = Code.compiler_options()
     Build.set_compiler_options(ignore_module_conflict: true)

apps/language_server/test/tracer_test.exs

@@ -14,18 +14,16 @@ defmodule ElixirLS.LanguageServer.TracerTest do
 
   test "set project dir" do
     project_path = FixtureHelpers.get_path("")
-    :persistent_term.put(:language_server_project_dir, project_path)
 
-    Tracer.notify_settings_stored()
+    Tracer.notify_settings_stored(project_path)
 
     assert GenServer.call(Tracer, :get_project_dir) == project_path
   end
 
   describe "call trace" do
     setup context do
       project_path = FixtureHelpers.get_path("")
-      :persistent_term.put(:language_server_project_dir, project_path)
-      Tracer.notify_settings_stored()
+      Tracer.notify_settings_stored(project_path)
       GenServer.call(Tracer, :get_project_dir)
 
       {:ok, context}