fix warnings

Author: lukaszsamson

apps/language_server/lib/language_server/parser.ex

@@ -148,7 +148,7 @@ defmodule ElixirLS.LanguageServer.Parser do
         %Context{source_file: %SourceFile{version: old_version}} = old_file
         when current_version > old_version ->
           # replace updated file with new version
-          %Context{old_file | source_file: source_file}
+          %{old_file | source_file: source_file}
 
         %Context{} = old_file ->
           # ignore this request - this or newer version already in state
@@ -192,7 +192,7 @@ defmodule ElixirLS.LanguageServer.Parser do
 
             %Context{source_file: %SourceFile{version: old_version}} = old_file
             when old_version <= current_version ->
-              %Context{old_file | source_file: source_file}
+              %{old_file | source_file: source_file}
           end
 
         {pid, ref} =

apps/language_server/lib/language_server/providers/code_action/helpers.ex

@@ -5,16 +5,16 @@ defmodule ElixirLS.LanguageServer.Providers.CodeAction.Helpers do
   @spec update_line(GenLSP.Structures.TextEdit.t(), non_neg_integer()) ::
           GenLSP.Structures.TextEdit.t()
   def update_line(
-        %GenLSP.Structures.TextEdit{range: range} = text_edit,
+        %GenLSP.Structures.TextEdit{range: %GenLSP.Structures.Range{} = range} = text_edit,
         line_number
       ) do
-    %GenLSP.Structures.TextEdit{
+    %GenLSP.Structures.Position{} = start_pos = range.start
+    %GenLSP.Structures.Position{} = end_pos = range.end
+    
+    %{
       text_edit
-      | range: %GenLSP.Structures.Range{
-          range
-          | start: %GenLSP.Structures.Position{range.start | line: line_number},
-            end: %GenLSP.Structures.Position{range.end | line: line_number}
-        }
+      | range: %{range | start: %{start_pos | line: line_number},
+                        end: %{end_pos | line: line_number}}
     }
   end
 

apps/language_server/lib/language_server/providers/code_mod/diff.ex

@@ -43,7 +43,7 @@ defmodule ElixirLS.LanguageServer.Providers.CodeMod.Diff do
          ]
        )
        when byte_size(insert_text) > 0 do
-    collapsed_edit = %TextEdit{delete_edit | new_text: insert_text}
+    collapsed_edit = %{delete_edit | new_text: insert_text}
     [collapsed_edit | rest]
   end
 

apps/language_server/lib/language_server/providers/completion.ex

@@ -592,11 +592,11 @@ defmodule ElixirLS.LanguageServer.Providers.Completion do
         &("alias " <> &1)
       )
 
+    %CompletionItem{} = completion_item = completion_without_additional_text_edit.completion_item
+    
     %__MODULE__{
       priority: 24,
-      completion_item: %CompletionItem{
-        completion_without_additional_text_edit.completion_item
-        | additional_text_edit: %GenLSP.Structures.TextEdit{
+      completion_item: %{completion_item | additional_text_edit: %GenLSP.Structures.TextEdit{
             range: %GenLSP.Structures.Range{
               start: %GenLSP.Structures.Position{line: line_to_insert_alias, character: 0},
               end: %GenLSP.Structures.Position{line: line_to_insert_alias, character: 0}
@@ -1023,9 +1023,10 @@ defmodule ElixirLS.LanguageServer.Providers.Completion do
     if completion do
       completion =
         if name in @operators do
+          %CompletionItem{} = completion_item = completion.completion_item
           %__MODULE__{
             completion
-            | completion_item: %CompletionItem{completion.completion_item | kind: :operator}
+            | completion_item: %{completion_item | kind: :operator}
           }
         else
           completion
@@ -1049,11 +1050,10 @@ defmodule ElixirLS.LanguageServer.Providers.Completion do
               &("require " <> &1)
             )
 
+          %CompletionItem{} = completion_item = completion.completion_item
           %__MODULE__{
             completion
-            | completion_item: %CompletionItem{
-                completion.completion_item
-                | additional_text_edit: %GenLSP.Structures.TextEdit{
+            | completion_item: %{completion_item | additional_text_edit: %GenLSP.Structures.TextEdit{
                     range: %GenLSP.Structures.Range{
                       start: %GenLSP.Structures.Position{
                         line: line_to_insert_require,
@@ -1073,13 +1073,10 @@ defmodule ElixirLS.LanguageServer.Providers.Completion do
       file_path = Keyword.get(options, :file_path)
 
       if snippet = snippet_for({origin, name}, Map.put(context, :file_path, file_path)) do
+        %CompletionItem{} = completion_item = completion.completion_item
         %__MODULE__{
           completion
-          | completion_item: %CompletionItem{
-              completion.completion_item
-              | insert_text: snippet,
-                label: name
-            }
+          | completion_item: %{completion_item | insert_text: snippet, label: name}
         }
       else
         completion

apps/language_server/lib/language_server/server.ex

@@ -707,11 +707,11 @@ defmodule ElixirLS.LanguageServer.Server do
       state
     else
       state =
-        update_in(state.source_files[uri], fn source_file ->
+        update_in(state.source_files[uri], fn %SourceFile{} = source_file ->
           # LSP 3.17: The version number points to the version after all provided content changes have
           # been applied
           updated_source_file =
-            %SourceFile{source_file | version: version, dirty?: true}
+            %{source_file | version: version, dirty?: true}
             |> SourceFile.apply_content_changes(content_changes)
 
           Parser.parse_with_debounce(uri, updated_source_file)
@@ -817,7 +817,7 @@ defmodule ElixirLS.LanguageServer.Server do
             %SourceFile{text: source_file_text, dirty?: true} = source_file ->
               case File.read(SourceFile.Path.from_uri(uri)) do
                 {:ok, ^source_file_text} ->
-                  Map.put(acc, uri, %SourceFile{source_file | dirty?: false})
+                  Map.put(acc, uri, %{source_file | dirty?: false})
 
                 {:ok, _} ->
                   acc
@@ -2003,7 +2003,7 @@ defmodule ElixirLS.LanguageServer.Server do
           # diagnostics without file are meaningless in LSP, try to point to mixfile instead
           if project_dir != nil and mix_project? do
             file = Path.join(project_dir, MixfileHelpers.mix_exs())
-            %Diagnostics{diagnostic | file: file, source: file, position: 0}
+            %{diagnostic | file: file, source: file, position: 0}
           end
         end
       end)