handle atom args better

Author: lukaszsamson

lib/elixir_sense/core/binding.ex

@@ -1647,7 +1647,7 @@ defmodule ElixirSense.Core.Binding do
   defp parse_type(_env, _type, _, _include_private, _stack), do: nil
 
   defp expand_type(env, mod, type_name, args, include_private, stack) do
-    arity = length(args || [])
+    arity = if(is_list(args), do: length(args), else: 0)
     type = {mod, type_name, arity}
 
     if type in stack do
@@ -1659,7 +1659,7 @@ defmodule ElixirSense.Core.Binding do
   end
 
   defp do_expand_type(env, mod, type_name, args, include_private, stack) do
-    arity = length(args || [])
+    arity = if(is_list(args), do: length(args), else: 0)
 
     case expand_type_from_metadata(env, mod, type_name, arity, include_private, stack) do
       nil -> expand_type_from_introspection(env, mod, type_name, arity, include_private, stack)

lib/elixir_sense/core/compiler.ex

@@ -861,7 +861,7 @@ defmodule ElixirSense.Core.Compiler do
               fa =
                 case list do
                   [{f, _, a} | _] ->
-                    {f, length(a || [])}
+                    {f, if(is_list(a), do: length(a), else: 0)}
 
                   _ ->
                     {:__unknown__, 0}
@@ -1707,7 +1707,7 @@ defmodule ElixirSense.Core.Compiler do
           fa =
             case list do
               [{f, _, a} | _] ->
-                {f, length(a || [])}
+                {f, if(is_list(a), do: length(a), else: 0)}
 
               _ ->
                 {:__unknown__, 0}

lib/elixir_sense/core/compiler/typespec.ex

@@ -13,7 +13,7 @@ defmodule ElixirSense.Core.Compiler.Typespec do
       when is_list(args) do
     case args do
       [{n, _, a} | _] ->
-        {n, a || []}
+        {n, if(is_list(a), do: a, else: [])}
 
       _ ->
         # type name replaced by cursor
@@ -28,7 +28,7 @@ defmodule ElixirSense.Core.Compiler.Typespec do
   def type_to_signature({:__cursor__, _, args}) when is_list(args) do
     case args do
       [{n, _, a} | _] ->
-        {n, a || []}
+        {n, if(is_list(a), do: a, else: [])}
 
       _ ->
         # type name replaced by cursor

lib/elixir_sense/core/introspection.ex

@@ -487,7 +487,7 @@ defmodule ElixirSense.Core.Introspection do
   def to_string_with_parens({name, meta, args}) when is_atom(name) do
     if ElixirSense.Core.Normalized.Code.Formatter.local_without_parens?(
          name,
-         length(args || []),
+         if(is_list(args), do: length(args), else: 0),
          ElixirSense.Core.Normalized.Code.Formatter.locals_without_parens()
        ) do
       # Macro.to_string formats some locals without parens
@@ -688,7 +688,7 @@ defmodule ElixirSense.Core.Introspection do
   end
 
   def extract_fun_args({{_fun, _}, _line, _kind, args, _doc, _metadata}) do
-    (args || [])
+    if(is_list(args), do: args, else: [])
     |> Enum.map(&format_doc_arg(&1))
   end
 
@@ -736,7 +736,7 @@ defmodule ElixirSense.Core.Introspection do
       spec = Map.get(specs, {f, a})
 
       formatted_args =
-        (args || [])
+        if(is_list(args), do: args, else: [])
         |> Enum.map(&format_doc_arg(&1))
 
       desc = extract_summary_from_docs(doc)

lib/elixir_sense/core/options.ex

@@ -346,7 +346,7 @@ defmodule ElixirSense.Core.Options do
 
   def do_expand_type({name, meta, args}, metadata, module, named_args, stack)
       when is_atom(name) do
-    args = (args || []) |> Enum.map(&expand_type(&1, metadata, module, named_args, stack))
+    args = if(is_list(args), do: args, else: []) |> Enum.map(&expand_type(&1, metadata, module, named_args, stack))
     named_arg = Keyword.fetch(named_args, name)
 
     cond do
@@ -410,7 +410,7 @@ defmodule ElixirSense.Core.Options do
   def do_expand_type(literal, _metadata, _module, _named_args, _stack), do: literal
 
   defp find_type(module, name, args, metadata) do
-    args = args || []
+    args = if(is_list(args), do: args, else: [])
 
     case metadata.types[{module, name, length(args)}] do
       nil ->