address todo

Author: lukaszsamson

lib/elixir_sense/core/introspection.ex

@@ -184,10 +184,10 @@ defmodule ElixirSense.Core.Introspection do
 
   defp get_spec_from_typespec(mod, fun) do
     # TypeInfo.get_function_specs does fallback to behaviours
-    {behaviour, specs} = TypeInfo.get_function_specs(mod, fun, :any)
+    function_specs = TypeInfo.get_function_specs(mod, fun, :any)
 
     results =
-      for {{_name, _arity}, [params | _]} = spec <- specs do
+      for {behaviour, specs} <- function_specs, {{_name, _arity}, [params | _]} = spec <- specs do
         params = TypeInfo.extract_params(params)
 
         %{

lib/elixir_sense/core/options.ex

@@ -135,14 +135,16 @@ defmodule ElixirSense.Core.Options do
                   {:macro, :"MACRO-#{function}", arity + 1, parameter_position_range}
               end
 
-            {_behaviour, specs} =
+            function_specs =
               ElixirSense.Core.TypeInfo.get_function_specs(
                 module,
                 modified_function,
                 modified_arity
               )
 
-            for {_, spec_entries} <- specs, spec <- spec_entries do
+            for {_behaviour, specs} <- function_specs,
+                {_, spec_entries} <- specs,
+                spec <- spec_entries do
               spec = maybe_unpack_caller(spec, kind)
 
               NormalizedTypespec.spec_to_quoted(function, spec)

lib/elixir_sense/core/type_info.ex

@@ -316,14 +316,12 @@ defmodule ElixirSense.Core.TypeInfo do
       end
 
     if function_specs != [] do
-      {nil, function_specs}
+      [{nil, function_specs}]
     else
-      # TODO this will not work correctly for :any arity in case many functions with the same name and different arities
-      # are implement different behaviours
       callback_specs =
         module
         |> Behaviours.get_module_behaviours()
-        |> Enum.reduce_while(nil, fn behaviour, acc ->
+        |> Enum.reduce_while([], fn behaviour, acc ->
           behaviour_specs = behaviour |> get_module_callbacks()
 
           callback_specs =
@@ -334,7 +332,11 @@ defmodule ElixirSense.Core.TypeInfo do
             end
 
           if callback_specs != [] do
-            {:halt, {behaviour, callback_specs}}
+            if arity == :any do
+              {:halt, [{behaviour, callback_specs}]}
+            else
+              {:cont, [{behaviour, callback_specs} | acc]}
+            end
           else
             {:cont, acc}
           end
@@ -343,7 +345,7 @@ defmodule ElixirSense.Core.TypeInfo do
       if callback_specs do
         callback_specs
       else
-        {nil, []}
+        [{nil, []}]
       end
     end
   end

lib/elixir_sense/providers/hover/docs.ex

@@ -495,18 +495,18 @@ defmodule ElixirSense.Providers.Hover.Docs do
 
   defp get_func_docs_from_typespec(mod, fun, call_arity) do
     # TypeInfo.get_function_specs does fallback to behaviours
-    {behaviour, specs} = TypeInfo.get_function_specs(mod, fun, call_arity)
+    function_specs = TypeInfo.get_function_specs(mod, fun, call_arity)
     app = ElixirSense.Core.Applications.get_application(mod)
 
-    meta =
-      if behaviour do
-        %{implementing: behaviour}
-      else
-        %{}
-      end
-
     results =
-      for {{_name, arity}, [params | _]} <- specs do
+      for {behaviour, specs} <- function_specs, {{_name, arity}, [params | _]} <- specs do
+        meta =
+          if behaviour do
+            %{implementing: behaviour}
+          else
+            %{}
+          end
+
         fun_args_text = TypeInfo.extract_params(params)
 
         %{