Skip to content

Commit 301b779

Browse files
authored
Don't log GOAWAY every time (#398)
1 parent eb2ab77 commit 301b779

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

lib/mint/http2.ex

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1408,9 +1408,7 @@ defmodule Mint.HTTP2 do
14081408

14091409
defp handle_consumed_all_frames(%{state: state} = conn, responses) do
14101410
case state do
1411-
{:goaway, :no_error, debug_data} ->
1412-
message = "Server closed connection normally (with debug data: #{inspect(debug_data)})"
1413-
log(conn, :debug, message)
1411+
{:goaway, :no_error, _debug_data} ->
14141412
{conn, responses}
14151413

14161414
{:goaway, error_code, debug_data} ->
@@ -1995,6 +1993,14 @@ defmodule Mint.HTTP2 do
19951993
{[{:error, stream.ref, wrap_error(:unprocessed)}], conn_acc}
19961994
end)
19971995

1996+
message =
1997+
case error_code do
1998+
:no_error -> "Server closed connection normally"
1999+
_other -> "Server closed connection with error #{inspect(error_code)}"
2000+
end
2001+
2002+
log(conn, :debug, "#{message} (with debug data: #{inspect(debug_data)})")
2003+
19982004
conn = put_in(conn.state, {:goaway, error_code, debug_data})
19992005
{conn, unprocessed_request_responses ++ responses}
20002006
end

0 commit comments

Comments
 (0)