Skip to content

Commit 633db2f

Browse files
authored
fix: test on stable ordering instead of ref-dependent order (#1537)
1 parent 762d3ee commit 633db2f

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

nx/test/nx/defn/tree_test.exs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ defmodule Nx.Defn.TreeTest do
4040

4141
test "ignores constants" do
4242
a = Expr.parameter(:root, {:u, 64}, {}, 0)
43-
assert [{_, :parameter}, {_, :add}] = plus_constant(a) |> Tree.scope_ids() |> Enum.sort()
43+
44+
assert [{_, :add}, {_, :parameter}] =
45+
plus_constant(a) |> Tree.scope_ids() |> Enum.sort_by(&elem(&1, 1))
4446
end
4547

4648
defn inside_cond(bool, a, b) do
@@ -54,8 +56,8 @@ defmodule Nx.Defn.TreeTest do
5456
test "ignores expressions inside cond" do
5557
{bool, cond} = Nx.Defn.jit(&{&1, inside_cond(&1, &2, &3)}).(0, 1, 2)
5658

57-
assert cond |> Tree.scope_ids() |> Enum.sort() ==
58-
[{bool.data.id, :parameter}, {cond.data.id, :cond}]
59+
assert cond |> Tree.scope_ids() |> Enum.sort_by(&elem(&1, 1)) ==
60+
[{cond.data.id, :cond}, {bool.data.id, :parameter}]
5961
end
6062

6163
defn inside_both_cond(bool, a, b) do
@@ -84,14 +86,14 @@ defmodule Nx.Defn.TreeTest do
8486
b = Expr.parameter(:root, {:u, 64}, {}, 2)
8587

8688
assert [
87-
{_, :parameter},
88-
{_, :parameter},
89-
{_, :parameter},
9089
{_, :add},
9190
{_, :cond},
9291
{_, :cond},
93-
{_, :multiply}
94-
] = inside_both_cond(bool, a, b) |> Tree.scope_ids() |> Enum.sort()
92+
{_, :multiply},
93+
{_, :parameter},
94+
{_, :parameter},
95+
{_, :parameter}
96+
] = inside_both_cond(bool, a, b) |> Tree.scope_ids() |> Enum.sort_by(&elem(&1, 1))
9597
end
9698
end
9799

0 commit comments

Comments
 (0)