Skip to content

Commit bb056ce

Browse files
authored
refactor: remove tuples from EXLA (#1463)
1 parent 087845b commit bb056ce

File tree

13 files changed

+99
-177
lines changed

13 files changed

+99
-177
lines changed

exla/c_src/exla/exla.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -603,8 +603,6 @@ static ErlNifFunc exla_funcs[] = {
603603
{"get_mlir_function_arguments", 1, get_mlir_function_arguments},
604604
{"mlir_add", 3, mlir_add},
605605
{"mlir_subtract", 3, mlir_subtract},
606-
{"mlir_tuple", 2, mlir_tuple},
607-
{"mlir_get_tuple_element", 3, mlir_get_tuple_element},
608606
{"mlir_multiply", 3, mlir_multiply},
609607
{"mlir_min", 3, mlir_min},
610608
{"mlir_max", 3, mlir_max},

exla/c_src/exla/mlir/ops.cc

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -153,50 +153,6 @@ ERL_NIF_TERM get_mlir_function_arguments(ErlNifEnv* env, int argc, const ERL_NIF
153153
return exla::nif::ok(env, enif_make_list_from_array(env, terms.data(), terms.size()));
154154
}
155155

156-
ERL_NIF_TERM mlir_tuple(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]) {
157-
if (argc != 2) {
158-
return exla::nif::error(env, "Bad argument count.");
159-
}
160-
161-
exla::MLIRFunction** function;
162-
std::vector<mlir::Value> vals;
163-
164-
if (!exla::nif::get<exla::MLIRFunction*>(env, argv[0], function)) {
165-
return exla::nif::error(env, "Unable to get function.");
166-
}
167-
if (!exla::nif::get_list<mlir::Value>(env, argv[1], vals)) {
168-
return exla::nif::error(env, "Unable to get values.");
169-
}
170-
171-
mlir::Value res = (*function)->TupleOp(vals);
172-
173-
return exla::nif::ok(env, exla::nif::make<mlir::Value>(env, res));
174-
}
175-
176-
ERL_NIF_TERM mlir_get_tuple_element(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]) {
177-
if (argc != 3) {
178-
return exla::nif::error(env, "Bad argument count.");
179-
}
180-
181-
exla::MLIRFunction** function;
182-
mlir::Value* tuple;
183-
exla::int64 index;
184-
185-
if (!exla::nif::get<exla::MLIRFunction*>(env, argv[0], function)) {
186-
return exla::nif::error(env, "Unable to get function.");
187-
}
188-
if (!exla::nif::get<mlir::Value>(env, argv[1], tuple)) {
189-
return exla::nif::error(env, "Unable to get tuple.");
190-
}
191-
if (!exla::nif::get(env, argv[2], &index)) {
192-
return exla::nif::error(env, "Unable to get index.");
193-
}
194-
195-
mlir::Value res = (*function)->GetTupleElementOp(*tuple, index);
196-
197-
return exla::nif::ok(env, exla::nif::make<mlir::Value>(env, res));
198-
}
199-
200156
ERL_NIF_TERM mlir_binary_op(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[], std::function<mlir::Value(exla::MLIRFunction*, mlir::Value*, mlir::Value*)> op) {
201157
if (argc != 3) {
202158
return exla::nif::error(env, "Bad argument count.");

exla/c_src/exla/mlir/ops.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ DEFINE_NIF(new_mlir_module);
99
DEFINE_NIF(new_mlir_context);
1010
DEFINE_NIF(create_mlir_function);
1111
DEFINE_NIF(get_mlir_function_arguments);
12-
DEFINE_NIF(mlir_tuple);
13-
DEFINE_NIF(mlir_get_tuple_element);
1412

1513
// Binary Ops
1614
DEFINE_NIF(mlir_add);

0 commit comments

Comments
 (0)