Fix CI artifact upload with tag release

Author: jonatanklosko

.github/scripts/upload_artifact.sh

@@ -4,13 +4,13 @@ set -ex
 
 cd "$(dirname "$0")/../.."
 
-ref="$1"
+sha="$1"
 release_name="$2"
 files="${@:3}"
 
 # Create the release, if not present.
 if ! gh release view $release_name; then
-  gh release create $release_name --title $release_name --draft --target $ref
+  gh release create $release_name --title $release_name --draft --target $sha
 fi
 
 # Uploading is the final action after several hour long build, so in

.github/workflows/release.yml

@@ -5,7 +5,7 @@ on:
       - "v*.*.*"
 
 env:
-  NX_XLA_REF: ${{ github.ref_name }}
+  NX_XLA_SHA: ${{ github.sha }}
   NX_XLA_RELEASE_NAME: ${{ github.ref_name }}
 
   # Build envs for non-Docker jobs.
@@ -22,9 +22,9 @@ jobs:
       - run: rm -rf /opt/hostedtoolcache
       - uses: actions/checkout@v4
         with:
-          ref: ${{ env.NX_XLA_REF }}
+          ref: ${{ env.NX_XLA_SHA }}
       - run: builds/build.sh cpu
-      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_REF }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
+      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_SHA }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -36,9 +36,9 @@ jobs:
       - run: rm -rf /opt/hostedtoolcache
       - uses: actions/checkout@v4
         with:
-          ref: ${{ env.NX_XLA_REF }}
+          ref: ${{ env.NX_XLA_SHA }}
       - run: builds/build.sh cuda12
-      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_REF }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
+      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_SHA }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -50,9 +50,9 @@ jobs:
       - run: rm -rf /opt/hostedtoolcache
       - uses: actions/checkout@v4
         with:
-          ref: ${{ env.NX_XLA_REF }}
+          ref: ${{ env.NX_XLA_SHA }}
       - run: builds/build.sh tpu
-      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_REF }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
+      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_SHA }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -64,9 +64,9 @@ jobs:
       - run: rm -rf /opt/hostedtoolcache
       - uses: actions/checkout@v4
         with:
-          ref: ${{ env.NX_XLA_REF }}
+          ref: ${{ env.NX_XLA_SHA }}
       - run: builds/build.sh cpu
-      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_REF }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
+      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_SHA }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -78,9 +78,9 @@ jobs:
       - run: rm -rf /opt/hostedtoolcache
       - uses: actions/checkout@v4
         with:
-          ref: ${{ env.NX_XLA_REF }}
+          ref: ${{ env.NX_XLA_SHA }}
       - run: builds/build.sh cuda12
-      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_REF }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
+      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_SHA }} ${{ env.NX_XLA_RELEASE_NAME }} builds/output/*/cache/*/build/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -90,7 +90,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: ${{ env.NX_XLA_REF }}
+          ref: ${{ env.NX_XLA_SHA }}
       - run: brew install elixir
       - run: mix local.hex --force
       # Setup the compilation environment
@@ -111,7 +111,7 @@ jobs:
           # this flag is not passed in the first place.
           # See https://github.com/tensorflow/tensorflow/pull/87514
           BUILD_FLAGS: "--define=xnn_enable_avxvnniint8=false"
-      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_REF }} ${{ env.NX_XLA_RELEASE_NAME }} tmp/cache/*/build/*
+      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_SHA }} ${{ env.NX_XLA_RELEASE_NAME }} tmp/cache/*/build/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -121,7 +121,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: ${{ env.NX_XLA_REF }}
+          ref: ${{ env.NX_XLA_SHA }}
       - run: brew install elixir
       - run: mix local.hex --force
       # Setup the compilation environment
@@ -135,6 +135,6 @@ jobs:
       - run: mix compile
         env:
           XLA_TARGET: cpu
-      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_REF }} ${{ env.NX_XLA_RELEASE_NAME }} tmp/cache/*/build/*
+      - run: .github/scripts/upload_artifact.sh ${{ env.NX_XLA_SHA }} ${{ env.NX_XLA_RELEASE_NAME }} tmp/cache/*/build/*
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}