Skip to content

compilation warnings with > 1.19: Converting the struct update syntax into type assertionsΒ #421

@ndrean

Description

@ndrean

Some minor compilation warnings as "Elixir should warn if you use the struct update syntax without pattern matching on the struct"

Protobuf.DSL.parse_field_opts_to_field_props
Protobuf.DSL.Protobuf.DSL.cal_json_name
Protobuf.Protoc.Generator.Extension.get_extensions_from_messages
Protobuf.DSL.cal_packed
Protobuf.Protoc.CLI.parse_param

defp parse_param("one_file_per_module=" <> value, %Context{} = ctx) do
                                                       ^^^
    case value do
      "true" ->
        %{ctx | one_file_per_module?: true}
      ^^^

Maybe update .github/worflows to catch this

jobs:
  test:
    name: Test (Elixir ${{ matrix.elixir }} | Erlang/OTP ${{ matrix.otp }})
    runs-on: ubuntu-22.04
    strategy:
      fail-fast: false
      matrix:
        include:
          ...
          - otp: 28.x
            elixir: 1.19.x

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions