Skip to content

Commit e15ad58

Browse files
address comments
1 parent 8463e07 commit e15ad58

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

lib/pointing_party_web/controllers/session_controller.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ defmodule PointingPartyWeb.SessionController do
1010

1111
def create(conn, params) do
1212
case Auth.login(params["account"]) do
13-
{:ok, account} ->
14-
put_session(conn, :username, account.username)
13+
{:ok, %{username: username}} ->
14+
put_session(conn, :username, username)
1515
|> redirect(to: "/cards") |> halt()
1616
{:error, changeset} ->
1717
render(conn, "new.html", changeset: changeset)

lib/pointing_party_web/plugs/auth.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ defmodule PointingPartyWeb.Plugs.Auth do
66

77
def call(conn, _default) do
88
case authenticate(conn) do
9-
nil -> redirect(conn, to: "/login") |> halt()
9+
nil -> conn |> redirect(to: "/login") |> halt()
1010
username -> assign(conn, :username, username)
1111
end
1212
end

lib/pointing_party_web/views/layout_helpers.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ defmodule PointingPartyWeb.LayoutHelpers do
55
Generates tag for inlined form input errors.
66
"""
77
def signed_in?(conn) do
8-
conn.assigns[:username]
8+
not is_nil(conn.assigns[:username])
99
end
1010
end

0 commit comments

Comments
 (0)