Fix linter errors

Author: Verseth

completion.go

@@ -108,8 +108,8 @@ func (c *CompletionManager) update() {
 }
 
 func deleteBreakLineCharacters(s string) string {
-	s = strings.Replace(s, "\n", "", -1)
-	s = strings.Replace(s, "\r", "", -1)
+	s = strings.ReplaceAll(s, "\n", "")
+	s = strings.ReplaceAll(s, "\r", "")
 	return s
 }
 

history.go

@@ -85,12 +85,14 @@ func (h *History) DeleteAll() {
 	h.selected = 0
 }
 
+const defaultHistorySize = 500
+
 // NewHistory returns new history object.
 func NewHistory() *History {
 	return &History{
 		histories: []string{},
 		tmp:       []string{""},
 		selected:  0,
-		size:      500,
+		size:      defaultHistorySize,
 	}
 }

history_test.go

@@ -13,7 +13,7 @@ func TestHistoryClear(t *testing.T) {
 		histories: []string{"foo"},
 		tmp:       []string{"foo", ""},
 		selected:  1,
-		size:      1000,
+		size:      defaultHistorySize,
 	}
 	if !reflect.DeepEqual(expected, h) {
 		t.Errorf("Should be %#v, but got %#v", expected, h)
@@ -27,7 +27,7 @@ func TestHistoryAdd(t *testing.T) {
 		histories: []string{"echo 1"},
 		tmp:       []string{"echo 1", ""},
 		selected:  1,
-		size:      1000,
+		size:      defaultHistorySize,
 	}
 	if !reflect.DeepEqual(h, expected) {
 		t.Errorf("Should be %v, but got %v", expected, h)

prompt.go

@@ -57,7 +57,6 @@ type Prompt struct {
 	executeOnEnterCallback ExecuteOnEnterCallback
 	skipClose              bool
 	completionReset        bool
-	parseHistoryCommands   bool
 }
 
 // UserInput is the struct that contains the user input context.

renderer.go

@@ -307,10 +307,7 @@ func (r *Renderer) getMultilinePrefix(prefix string) string {
 	var spaceCount int
 	var dotCount int
 	var nonSpaceCharSeen bool
-	for {
-		if len(prefix) == 0 {
-			break
-		}
+	for len(prefix) != 0 {
 		char, size := utf8.DecodeLastRuneInString(prefix)
 		prefix = prefix[:len(prefix)-size]
 		charWidth := istrings.GetRuneWidth(char)

writer_vt100.go

@@ -16,7 +16,7 @@ var _ io.StringWriter = &VT100Writer{}
 
 // Write to write safety byte array by removing control sequences.
 func (w *VT100Writer) Write(data []byte) (int, error) {
-	w.WriteRaw(bytes.Replace(data, []byte{0x1b}, []byte{'?'}, -1))
+	w.WriteRaw(bytes.ReplaceAll(data, []byte{0x1b}, []byte{'?'}))
 	return len(data), nil
 }
 
@@ -198,7 +198,7 @@ func (w *VT100Writer) SetTitle(title string) {
 		},
 	}
 	for i := range patterns {
-		titleBytes = bytes.Replace(titleBytes, patterns[i].from, patterns[i].to, -1)
+		titleBytes = bytes.ReplaceAll(titleBytes, patterns[i].from, patterns[i].to)
 	}
 
 	w.WriteRaw([]byte{0x1b, ']', '2', ';'})